Project

General

Profile

Actions
Copy link

Bug #7766

closed

ms_native dhcp smart proxy code scales poorly

Added by Dan Berger about 10 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
DHCP
Target version:
1.14.0
Difficulty:
hard
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/smart-proxy/pull/426, https://github.com/theforeman/smart-proxy/pull/445
Fixed in Releases:
Found in Releases:
Foreman - 1.5.2
Red Hat JIRA:

Description

the ms native dhcp server code (native_ms.rb) runs netsh commands per reservation - so in a scope with hundreds of reservations, selecting an unused address can take on the order of a minute.

I've reworked loadSubnetData and loadSubetOptions to parse the output of a dhcp server config dump, which takes runtime from ~1 minute to ~2 seconds - the patch isn't suitable for upstreaming, but I'd be happy to share more detail with someone interested in doing it "for real."

I've looked at the 1.6 and development versions of the file and they seem substantively similar in this regard.

Related issues 7 (1 open — 6 closed)

Related to Smart Proxy - Bug #6916: MS DHCP TimeoutResolved08/04/2014Actions
Related to Smart Proxy - Feature #4171: Smart proxy DHCP plugin does not honor exclude ranges Duplicate01/23/2014Actions
Related to Smart Proxy - Bug #1280: MS DHCP ignores address exclusionsResolvedActions
Related to Smart Proxy - Bug #16056: Non-english locale casuses "Vendor Class not found" errors when using windows dhcp providerResolved08/11/2016Actions
Related to Smart Proxy - Bug #15789: In MS DHCP provider general/Vendor options must exist before assigning values to themResolved07/22/2016Actions
Related to Smart Proxy - Feature #15554: Add lease deletion facility to dhcp providersNewPaul Kelly06/30/2016Actions
Related to Smart Proxy - Bug #13420: [Smart proxy] provider dhcp_native_ms DELETE method brokenResolved01/27/2016Actions
Actions
Copy link
 #1

Updated by Oliver Weinmann about 10 years ago

Hi Dan,

I have very similar issues where the smart proxy takes too long to register a new reservation and a timeout is reached and a host creation fails. I guess your fix could also fix this very very annoying issue.

Actions
Copy link
 #2

Updated by Dominic Cleal about 10 years ago

  • Related to Bug #6916: MS DHCP Timeout added
Actions
Copy link
 #3

Updated by The Foreman Bot over 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/277 added
  • Pull request deleted ()
Actions
Copy link
 #4

Updated by Anonymous over 9 years ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/294 added
  • Pull request deleted (https://github.com/theforeman/smart-proxy/pull/277)
Actions
Copy link
 #5

Updated by Oliver Weinmann over 9 years ago

Hi,

I'm happy to test, but the code contains static ip ranges?

Actions
Copy link
 #6

Updated by Oliver Weinmann over 9 years ago

Ok, i tested the 3 patched files with 1.82 and the dev branch. foreman is not able to find a free ip:

ERF12-4395 [ProxyAPI::ProxyException]: Unable to retrieve DHCP entry for 172.28.19.103 ([RestClient::BadRequest]: 400 Bad Request) for proxy https://gedasvw16.a.space.corp:8443/dhcp

from the proxy.log:

E, [2015-06-23T17:26:48.213031 #1748] ERROR -- : undefined method `each' for #<String:0x3a11c90>
D, [2015-06-23T17:26:48.213031 #1748] DEBUG -- : c:/foreman-proxy/modules/dhcp/providers/server/native_ms.rb:318:in `parse_options'
c:/foreman-proxy/modules/dhcp/providers/server/native_ms.rb:124:in `block in subnet_entries_to_records'
c:/foreman-proxy/modules/dhcp/providers/server/native_ms.rb:122:in `each'
c:/foreman-proxy/modules/dhcp/providers/server/native_ms.rb:122:in `subnet_entries_to_records'
c:/foreman-proxy/modules/dhcp/providers/server/native_ms.rb:150:in `loadSubnetData'
c:/foreman-proxy/modules/dhcp/subnet.rb:65:in `load'
c:/foreman-proxy/modules/dhcp/subnet.rb:75:in `records'
c:/foreman-proxy/modules/dhcp/server.rb:79:in `block in find_record'
c:/foreman-proxy/modules/dhcp/server.rb:78:in `each'
c:/foreman-proxy/modules/dhcp/server.rb:78:in `find_record'
c:/foreman-proxy/modules/dhcp/dhcp_api.rb:84:in `block in <class:DhcpApi>'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:1610:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:1610:in `block in compile!'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:974:in `[]'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:974:in `block (3 levels) in route!'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:993:in `route_eval'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:974:in `block (2 levels) in route!'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:1014:in `block in process_route'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:1012:in `catch'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:1012:in `process_route'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:972:in `block in route!'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:971:in `each'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:971:in `route!'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:1084:in `block in dispatch!'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:1066:in `block in invoke'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:1066:in `catch'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:1066:in `invoke'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:1081:in `dispatch!'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:906:in `block in call!'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:1066:in `block in invoke'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:1066:in `catch'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:1066:in `invoke'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:906:in `call!'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:894:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/rack-1.5.5/lib/rack/methodoverride.rb:21:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/rack-1.5.5/lib/rack/commonlogger.rb:33:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:218:in `call'
c:/foreman-proxy/lib/proxy/log.rb:35:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/rack-protection-1.5.3/lib/rack/protection/xss_header.rb:18:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/rack-protection-1.5.3/lib/rack/protection/path_traversal.rb:16:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/rack-protection-1.5.3/lib/rack/protection/json_csrf.rb:18:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/rack-protection-1.5.3/lib/rack/protection/base.rb:49:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/rack-protection-1.5.3/lib/rack/protection/base.rb:49:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/rack-protection-1.5.3/lib/rack/protection/frame_options.rb:31:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/rack-1.5.5/lib/rack/nulllogger.rb:9:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/rack-1.5.5/lib/rack/head.rb:11:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/show_exceptions.rb:21:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:181:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:2021:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:1486:in `block in call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:1795:in `synchronize'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/sinatra-1.4.6/lib/sinatra/base.rb:1486:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/rack-1.5.5/lib/rack/builder.rb:138:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/rack-1.5.5/lib/rack/urlmap.rb:65:in `block in call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/rack-1.5.5/lib/rack/urlmap.rb:50:in `each'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/rack-1.5.5/lib/rack/urlmap.rb:50:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/rack-1.5.5/lib/rack/builder.rb:138:in `call'
C:/Ruby193/lib/ruby/gems/1.9.1/gems/rack-1.5.5/lib/rack/handler/webrick.rb:60:in `service'
C:/Ruby193/lib/ruby/1.9.1/webrick/httpserver.rb:138:in `service'
C:/Ruby193/lib/ruby/1.9.1/webrick/httpserver.rb:94:in `run'
C:/Ruby193/lib/ruby/1.9.1/webrick/server.rb:191:in `block in start_thread'

Actions
Copy link
 #7

Updated by Oliver Weinmann over 9 years ago

Ok, got it.

I'm using ruby 1.9 and .each is no longer supported on a string.

in native_ms.rb

response.each do |line|

should be

response.each_line do |line|

BTW this code works a lot better. Please improve it and release it in 1.9! :)

Actions
Copy link
 #8

Updated by Dominic Cleal over 8 years ago

  • Status changed from Ready For Testing to New
  • Pull request deleted (https://github.com/theforeman/smart-proxy/pull/294)

PR closed.

Actions
Copy link
 #9

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/426 added
Actions
Copy link
 #10

Updated by The Foreman Bot over 8 years ago

  • Assignee set to Anonymous
  • Pull request https://github.com/theforeman/smart-proxy/pull/445 added
Actions
Copy link
 #11

Updated by Ivan Necas over 8 years ago

  • Target version set to 1.7.0
Actions
Copy link
 #12

Updated by Ivan Necas over 8 years ago

  • Target version changed from 1.7.0 to 1.6.1
Actions
Copy link
 #13

Updated by Anonymous over 8 years ago

  • Related to Feature #4171: Smart proxy DHCP plugin does not honor exclude ranges added
Actions
Copy link
 #14

Updated by Dominic Cleal over 8 years ago

  • Related to Bug #1280: MS DHCP ignores address exclusions added
Actions
Copy link
 #15

Updated by Anonymous over 8 years ago

  • Related to Bug #16056: Non-english locale casuses "Vendor Class not found" errors when using windows dhcp provider added
Actions
Copy link
 #16

Updated by Anonymous over 8 years ago

  • Related to Bug #15789: In MS DHCP provider general/Vendor options must exist before assigning values to them added
Actions
Copy link
 #17

Updated by Anonymous over 8 years ago

  • Related to Feature #15554: Add lease deletion facility to dhcp providers added
Actions
Copy link
 #18

Updated by Anonymous over 8 years ago

  • Related to Bug #13420: [Smart proxy] provider dhcp_native_ms DELETE method broken added
Actions
Copy link
 #19

Updated by Ivan Necas over 8 years ago

  • Target version changed from 1.6.1 to 127
Actions
Copy link
 #20

Updated by Ivan Necas about 8 years ago

  • Target version changed from 127 to 1.5.1
Actions
Copy link
 #21

Updated by Anonymous about 8 years ago

  • Project changed from Foreman to Smart Proxy
  • Category changed from Performance to DHCP
  • Difficulty changed from easy to hard
Actions
Copy link
 #22

Updated by Ivan Necas about 8 years ago

  • Target version changed from 1.5.1 to 1.4.1
Actions
Copy link
 #23

Updated by Anonymous about 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #24

Updated by Dominic Cleal about 8 years ago

  • Translation missing: en.field_release set to 189
Actions
Copy link

Also available in: Atom PDF