Project

General

Profile

Bug #7859

Ssh puppet run does not work on Ruby 1.9+

Added by Lukas Zapletal almost 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Puppet
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Things are not properly escaped:

D, [2014-10-09T10:53:50.238566 #17252] DEBUG -- : about to execute: ["/usr/bin/ssh", "-l", "lzap", "-i", "/home/lzap/.ssh/id_rsa", "lzapx.local.lan", "/home/lzap/.rbenv/shims/puppet\\ agent\\ --onetime\\ --no-usecacheonfailure"]
Warning: Permanently added 'lzapx.local.lan' (ECDSA) to the list of known hosts.
bash: /home/lzap/.rbenv/shims/puppet agent --onetime --no-usecacheonfailure: No such file or directory
W, [2014-10-09T10:53:50.332470 #17252]  WARN -- : Non-null exit code when executing '["/usr/bin/ssh", "-l", "lzap", "-i", "/home/lzap/.ssh/id_rsa", "lzapx.local.lan", "/home/lzap/.rbenv/shims/puppet\\ agent\\ --onetime\\ --no-usecacheonfailure"]'
::1 - - [09/Oct/2014 10:53:50] "POST /puppet/run HTTP/1.1" 200 - 0.1007
localhost - - [09/Oct/2014:10:53:50 CEST] "POST /puppet/run HTTP/1.1" 200 0
- -> /puppet/run

We already have a patch by Petr: https://github.com/theforeman/smart-proxy/pull/163

I am going to rebase/repatch/rewrite this on modularized proxy, the patch no longer apply.

Associated revisions

Revision ccd77aae (diff)
Added by Lukas Zapletal over 4 years ago

Fixes #7859 - puppetssh run works on Ruby 1.9+

History

#1 Updated by The Foreman Bot almost 5 years ago

  • Status changed from Assigned to Ready For Testing
  • Target version set to 1.7.2
  • Pull request https://github.com/theforeman/smart-proxy/pull/220 added
  • Pull request deleted ()

#2 Updated by Dominic Cleal almost 5 years ago

  • Category set to Puppet

#3 Updated by Anonymous over 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal over 4 years ago

  • Legacy Backlogs Release (now unused) set to 21

Also available in: Atom PDF