Bug #7859: Ssh puppet run does not work on Ruby 1.9+ - Smart Proxy - Foreman

Actions

Copy link

Bug #7859

closed

Ssh puppet run does not work on Ruby 1.9+

Added by Lukas Zapletal over 10 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Lukas Zapletal

Category:

Puppet

Target version:

1.7.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/smart-proxy/pull/220

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Things are not properly escaped:

D, [2014-10-09T10:53:50.238566 #17252] DEBUG -- : about to execute: ["/usr/bin/ssh", "-l", "lzap", "-i", "/home/lzap/.ssh/id_rsa", "lzapx.local.lan", "/home/lzap/.rbenv/shims/puppet\\ agent\\ --onetime\\ --no-usecacheonfailure"]
Warning: Permanently added 'lzapx.local.lan' (ECDSA) to the list of known hosts.
bash: /home/lzap/.rbenv/shims/puppet agent --onetime --no-usecacheonfailure: No such file or directory
W, [2014-10-09T10:53:50.332470 #17252]  WARN -- : Non-null exit code when executing '["/usr/bin/ssh", "-l", "lzap", "-i", "/home/lzap/.ssh/id_rsa", "lzapx.local.lan", "/home/lzap/.rbenv/shims/puppet\\ agent\\ --onetime\\ --no-usecacheonfailure"]'
::1 - - [09/Oct/2014 10:53:50] "POST /puppet/run HTTP/1.1" 200 - 0.1007
localhost - - [09/Oct/2014:10:53:50 CEST] "POST /puppet/run HTTP/1.1" 200 0
- -> /puppet/run

We already have a patch by Petr: https://github.com/theforeman/smart-proxy/pull/163

I am going to rebase/repatch/rewrite this on modularized proxy, the patch no longer apply.