Project

General

Profile

Bug #7971

DHCP conflict still triggered for non-conflicting leases

Added by Lukas Zapletal about 5 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Orchestration
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

When I was reproducing a bug related to pull request #1430 I noticed that in my
case (Ruby 2.0) it's not the self object without hostname set, but always
other object.

This check should be commutative, I am not sure if Ruby optimizes the call or
this has changed somehow in the runtime. But since hostname of the new host is
always set (we have a validator for this), adding commutative property should
not work.

I believe this should fix a problem I have with OpenStack (Discovery) installer
(RHBZ#1152516).


Related issues

Related to Foreman - Bug #5637: DHCP conflicts triggered for non-conflicting leasesClosed2014-05-08

Associated revisions

Revision 71dfb495 (diff)
Added by Lukas Zapletal almost 5 years ago

Fixes #7971 - DHCP hostname commutative conflict fix

Revision fdc6ff4d (diff)
Added by Lukas Zapletal almost 5 years ago

Fixes #7971 - DHCP hostname commutative conflict fix

(cherry picked from commit 71dfb49591ea842de62d9a404d77b1b71322a9a9)

History

#1 Updated by Lukas Zapletal about 5 years ago

  • Related to Bug #5637: DHCP conflicts triggered for non-conflicting leases added

#2 Updated by Lukas Zapletal about 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1861 added
  • Pull request deleted ()

#3 Updated by Lukas Zapletal almost 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal almost 5 years ago

  • Legacy Backlogs Release (now unused) set to 21

Also available in: Atom PDF