Project

General

Profile

Refactor #80

Reports data should be accessed in a simple way

Added by Ohad Levy over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Puppet Reports
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Currently report status is stored in one integer, it should be broken down into multiple database tables allowing to reduce the size of the database (by not storing the entire Puppet::Transaction::Report).

this should allow to search in a more rails way for all hosts that has a report with change count > 20


Related issues

Blocks Foreman - Bug #78: Puppet reports fails with 0.24.4-5 masterClosed2009-11-12

Associated revisions

Revision ff1cc6b1 (diff)
Added by Ohad Levy over 9 years ago

fixes #106 - redid the status calcuation, this fixes #80 but not in an optimal way - db migration would be required for that.

Revision 16cb7742 (diff)
Added by Ohad Levy over 9 years ago

fixes #80, fixes #106 and fixes #128

History

#1 Updated by Ohad Levy over 9 years ago

  • Target version deleted (0.1-3)

as the new version of puppet is going to be a massive rewrite of how reports are handled, I'm going to push this db schema changes until its clear what info puppet will provide.

additionally, I was never really happy with my ideas for the schema structure, so any ideas are welcomed.

#2 Updated by Ohad Levy over 9 years ago

I've created http://github.com/ohadlevy/foreman/tree/report_scopes

I think it solves all of the topics in this issue without changing the database schema - I'll appreciate a code review :)

#3 Updated by Ohad Levy over 9 years ago

Ohad Levy wrote:

I've created http://github.com/ohadlevy/foreman/tree/report_scopes

I think it solves all of the topics in this issue without changing the database schema - I'll appreciate a code review :)

well.. I've just learned that indexes do not work on bitwise columns.. even though I really like that code...

#4 Updated by Ohad Levy over 9 years ago

  • Target version set to 0.1-3

#5 Updated by Ohad Levy over 9 years ago

  • Status changed from New to Ready For Testing
  • % Done changed from 0 to 100

#6 Updated by Ohad Levy over 9 years ago

#7 Updated by Ohad Levy over 9 years ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF