Project

General

Profile

Bug #8005

Another autoloading o NIC models issue

Added by Marek Hulán almost 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

https://github.com/theforeman/foreman/commit/5da15d1ad20a71b65ad858d392e17fb46f074480 introduced a new issue of loading NIC models. Running specific tests fails because when loading Nic::Managed we loads Nic::Base which defined Nic::TYPES listing Nic::Managed (not loaded yet but in being loaded files array). Types are used only in API for listing values that can be used and it's converted to array of strings so we can safely define them as strings in class definition.


Related issues

Related to Foreman - Bug #7934: Autoloading of Nic models does not work in some casesClosed2014-10-14
Related to Foreman - Bug #8044: uninitialized constant Nic::Interface (NameError) when running sporkDuplicate2014-10-23

Associated revisions

Revision cad1b13c (diff)
Added by Tomáš Strachota almost 5 years ago

Fixes #8005 - Convert allowed NIC types to strings

- allowed NIC type classes need to be registered now
- api for interfaces use lowercase human readable values for defining types
- fixed output of api's create action to the standard format

History

#1 Updated by Marek Hulán almost 5 years ago

  • Related to Bug #7934: Autoloading of Nic models does not work in some cases added

#2 Updated by The Foreman Bot almost 5 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1866 added
  • Pull request deleted ()

#3 Updated by Marek Hulán almost 5 years ago

  • Assignee changed from Marek Hulán to Tomáš Strachota
  • Pull request https://github.com/theforeman/foreman/pull/1871 added
  • Pull request deleted (https://github.com/theforeman/foreman/pull/1866)

#4 Updated by Marek Hulán almost 5 years ago

  • Related to Bug #8044: uninitialized constant Nic::Interface (NameError) when running spork added

#5 Updated by Anonymous almost 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Dominic Cleal almost 5 years ago

  • Legacy Backlogs Release (now unused) set to 21

Also available in: Atom PDF