Bug #8133
closed
template diffs don't get displayed anymore
Description
After changing the content of a template, the event is still visible in the audit logs, clicking it and looking at "Template Diff", "No changes" is always displayed. This can also be seen in 1.6.1.
Updated by Anonymous about 10 years ago
- Related to Bug #7483: CVE-2014-3653 - Provisioning Templates Preview mode strips out text like <<FOO added
Updated by Anonymous about 10 years ago
I suspect the fix for #7483 introduced that problem.
Updated by Dominic Cleal about 10 years ago
- Status changed from New to Assigned
- Assignee set to Dominic Cleal
- Target version set to 1.7.2
Updated by The Foreman Bot about 10 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/1886 added
- Pull request deleted (
)
Updated by Daniel Lobato Garcia about 10 years ago
- Translation missing: en.field_release set to 21
Updated by Dominic Cleal about 10 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset ebf335e0d936be20e93e7b76217e46c813bfa548.
Updated by Pablo Escobar about 10 years ago
Hi
I have manually applied this patch to my 1.6.1 installation and I found a weird behaviour when using firefox.
When I click in the "show diff" link two new tabs are open in firefox. In both tabs the diff is shown correctly but I alwasy get two new tabs.
I have seem the same behaviour in Firefox 33.0 (Linux) and Firefox 32.0.3 (Mac)
When using chrome in Linux or Mac I don't see this problem. Just one tab is created.
Updated by Pablo Escobar about 10 years ago
Hi
I just realized that in chrome I was not observing this behaviour because of the pop-up blocker. When I disable the pop-up blocker in chrome I also get two new browser windows when clicking in "show diff"
Updated by Thomas Rohlik almost 9 years ago
Hi,
Template Diff is empty for me, even I was changed something.
I using Foreman 1.10 and Iceweasel web browser.
Updated by Dominic Cleal almost 9 years ago
Thomas Rohlik wrote:
Hi,
Template Diff is empty for me, even I was changed something.
I using Foreman 1.10 and Iceweasel web browser.
That is bug #12271. This bug report is very old (1.7) and not relevant.