Project

General

Profile

Bug #8133

template diffs don't get displayed anymore

Added by Michael Moll over 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

After changing the content of a template, the event is still visible in the audit logs, clicking it and looking at "Template Diff", "No changes" is always displayed. This can also be seen in 1.6.1.


Related issues

Related to Foreman - Bug #7483: CVE-2014-3653 - Provisioning Templates Preview mode strips out text like <<FOOClosed2014-09-16

Associated revisions

Revision ebf335e0 (diff)
Added by Dominic Cleal over 4 years ago

fixes #8133 - update audit diff view to match changes in cafa947

Revision 429b07c8 (diff)
Added by Dominic Cleal over 4 years ago

fixes #8133 - update audit diff view to match changes in cafa947

(cherry picked from commit ebf335e0d936be20e93e7b76217e46c813bfa548)

History

#1 Updated by Michael Moll over 4 years ago

  • Related to Bug #7483: CVE-2014-3653 - Provisioning Templates Preview mode strips out text like <<FOO added

#2 Updated by Michael Moll over 4 years ago

I suspect the fix for #7483 introduced that problem.

#3 Updated by Dominic Cleal over 4 years ago

  • Status changed from New to Assigned
  • Assignee set to Dominic Cleal
  • Target version set to 1.7.2

#4 Updated by The Foreman Bot over 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1886 added
  • Pull request deleted ()

#5 Updated by Daniel Lobato Garcia over 4 years ago

  • Legacy Backlogs Release (now unused) set to 21

#6 Updated by Dominic Cleal over 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#7 Updated by Pablo Escobar over 4 years ago

Hi

I have manually applied this patch to my 1.6.1 installation and I found a weird behaviour when using firefox.

When I click in the "show diff" link two new tabs are open in firefox. In both tabs the diff is shown correctly but I alwasy get two new tabs.

I have seem the same behaviour in Firefox 33.0 (Linux) and Firefox 32.0.3 (Mac)

When using chrome in Linux or Mac I don't see this problem. Just one tab is created.

#8 Updated by Pablo Escobar over 4 years ago

Hi

I just realized that in chrome I was not observing this behaviour because of the pop-up blocker. When I disable the pop-up blocker in chrome I also get two new browser windows when clicking in "show diff"

#9 Updated by Thomas Rohlik over 3 years ago

Hi,
Template Diff is empty for me, even I was changed something.
I using Foreman 1.10 and Iceweasel web browser.

#10 Updated by Dominic Cleal over 3 years ago

Thomas Rohlik wrote:

Hi,
Template Diff is empty for me, even I was changed something.
I using Foreman 1.10 and Iceweasel web browser.

That is bug #12271. This bug report is very old (1.7) and not relevant.

Also available in: Atom PDF