Project

General

Profile

Bug #815

Redirect to login page when editing multiple hosts

Added by Eric Shamow over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

In Foreman 0.2 final, when editing multiple hosts in the Hosts view, upon clicking submit the user is returned to the login screen.

Per ohadlevy in #theforeman:

it seems to be related to the fact that the ajax request doesnt contain the authentication_id, which probably happened when we upgraded rails
but I wanted to change the logic from ajax to store the selected hosts in a cookie instead
as the current implementation is not that solid

815.patch 815.patch 27.2 KB Ohad Levy, 04/22/2011 04:13 PM

Related issues

Related to Foreman - Bug #684: toggle selection is broken on hosts pageClosed2011-02-23

Associated revisions

Revision 1a51088d (diff)
Added by Ohad Levy over 9 years ago

fixes #815 - Redirect to login page when editing multiple hosts

this patch converts the mulitple selections to be pure javascript,
removing the buggy AJAX implementation.

Revision 078fbb59 (diff)
Added by Ohad Levy over 9 years ago

refs #815 - converted mulity host selections to a dialog box

  • added selected counter
  • checkbox are now always shown, disabled or enabled based on users permissions
  • cleanups

History

#1 Updated by Eric Shamow over 9 years ago

Meant to note -- this is running behind Passenger.

#2 Updated by Ohad Levy over 9 years ago

  • Assignee set to Bash Shell
  • Target version set to 0.3

#3 Updated by Ohad Levy over 9 years ago

so, inspired by ahuman patch, attached is my own.

this converts the entire selection to javascript, and remove the old dependency upon AJAX.
its still not complete, but 99% of the functionality should already be included, would be great if you could give it a try.

#4 Updated by Ohad Levy over 9 years ago

  • Status changed from New to Ready For Testing
  • % Done changed from 0 to 100

#5 Updated by Ohad Levy over 9 years ago

  • Status changed from Ready For Testing to Closed

#6 Updated by Bash Shell over 9 years ago

Nice .. I don't know when I will actually get to try this, but I was wondering if this works if you select a large number of hosts? ( say several hundred )

#7 Updated by Ohad Levy over 9 years ago

Bash Shell wrote:

Nice .. I don't know when I will actually get to try this, but I was wondering if this works if you select a large number of hosts? ( say several hundred )

as the cookie only saves the ids of a host, then I would assume our limit is about 1k hosts

Also available in: Atom PDF