Project

General

Profile

Refactor #8267

Refactor templates code to use parameters instead of a proxy api call

Added by Greg Sutcliffe almost 8 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Greg Sutcliffe
Category:
Templates
Target version:
1.8.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/smart-proxy/pull/232
Fixed in Releases:
Found in Releases:

Description

See https://github.com/theforeman/foreman/pull/1860#discussion_r19814502 for the context

Related issues

Blocks Foreman - Bug #8290: dry the foreman_url logic that exists in both renderer and host_templates_helperClosed2014-11-05

Associated revisions

Revision ab6edc29 (diff)
Added by Greg Sutcliffe over 7 years ago

Refs #8267 - pass template_url in call to foreman

Also passes the ?static parameter on correctly

Revision 1e4e77c6 (diff)
Added by Greg Sutcliffe over 7 years ago

Fixes #8267 - accept template_url in call to foreman from proxy

History

#1 Updated by The Foreman Bot almost 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/232 added
  • Pull request deleted ()

#2 Updated by dustin tsang almost 8 years ago

  • Related to Bug #8290: dry the foreman_url logic that exists in both renderer and host_templates_helper added

#3 Updated by dustin tsang almost 8 years ago

  • Related to deleted (Bug #8290: dry the foreman_url logic that exists in both renderer and host_templates_helper)

#4 Updated by dustin tsang almost 8 years ago

  • Blocks Bug #8290: dry the foreman_url logic that exists in both renderer and host_templates_helper added

#5 Updated by Greg Sutcliffe over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Dominic Cleal over 7 years ago

  • Legacy Backlogs Release (now unused) set to 28

Also available in: Atom PDF