Project

General

Profile

Bug #8290

dry the foreman_url logic that exists in both renderer and host_templates_helper

Added by dustin tsang over 7 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Timo Goebel
Category:
Templates
Target version:
1.15.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4148
Fixed in Releases:
Found in Releases:

Related issues

Related to Foreman - Bug #17636: Template preview requires token to be present for template proxyingClosed2016-12-12
Blocked by Foreman - Refactor #8267: Refactor templates code to use parameters instead of a proxy api callClosed2014-11-04
Blocks Foreman - Feature #8291: make foreman_url modifiable by a pluginNew2014-11-05

Associated revisions

Revision 276359d3 (diff)
Added by Timo Goebel over 5 years ago

fixes #8290 - remove foreman_url redundancy

History

#1 Updated by dustin tsang over 7 years ago

  • Related to Refactor #8267: Refactor templates code to use parameters instead of a proxy api call added

#2 Updated by dustin tsang over 7 years ago

  • Related to deleted (Refactor #8267: Refactor templates code to use parameters instead of a proxy api call)

#3 Updated by dustin tsang over 7 years ago

  • Blocked by Refactor #8267: Refactor templates code to use parameters instead of a proxy api call added

#4 Updated by The Foreman Bot over 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1904 added
  • Pull request deleted ()

#5 Updated by dustin tsang over 7 years ago

  • Blocks Feature #8291: make foreman_url modifiable by a plugin added

#6 Updated by Dominic Cleal over 7 years ago

  • Category set to Templates
  • Target version set to 1.7.2

#7 Updated by Dominic Cleal over 7 years ago

  • Status changed from Ready For Testing to New
  • Assignee deleted (dustin tsang)
  • Target version deleted (1.7.2)
  • Pull request added
  • Pull request deleted (https://github.com/theforeman/foreman/pull/1904)

PR's been closed by the author, but the issue still appears valid to me, so leaving this open.

#8 Updated by Lukas Zapletal over 5 years ago

  • Related to Bug #17636: Template preview requires token to be present for template proxying added

#9 Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Timo Goebel
  • Pull request https://github.com/theforeman/foreman/pull/4148 added

#10 Updated by Timo Goebel over 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#11 Updated by Dominic Cleal over 5 years ago

  • Legacy Backlogs Release (now unused) set to 209

Also available in: Atom PDF