Project

General

Profile

Bug #8442

Eager loading on audits page does not work

Added by Ohad Levy almost 7 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Database
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

ActiveRecord::EagerLoadPolymorphicError
Can not eagerly load the polymorphic association :user
app/views/audits/_list.html.erb:1:in `_53d8a19f5b9e17a52dbbf2112ae4186e'
app/views/audits/index.html.erb:3:in `_cde286859771808c11fbbbdf6d2f4212'
app/models/concerns/foreman/thread_session.rb:33:in `clear_thread'
lib/middleware/catch_json_parse_errors.rb:9:in `call'

Related issues

Related to Foreman - Bug #8425: n+1 query on audits indexClosed2014-11-17

Associated revisions

Revision 411ebf41 (diff)
Added by Joseph Magen almost 7 years ago

fixes #8442 - add eager loading of users on audit show page for history tab

History

#1 Updated by Ohad Levy almost 7 years ago

  • Related to Bug #8425: n+1 query on audits index added

#2 Updated by Dominic Cleal almost 7 years ago

  • Category set to Database
  • Priority changed from Normal to High
  • Legacy Backlogs Release (now unused) set to 28

#3 Updated by Shlomi Zadok almost 7 years ago

  • Assignee set to Shlomi Zadok

#4 Updated by The Foreman Bot almost 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1964 added
  • Pull request deleted ()

#5 Updated by Joseph Magen almost 7 years ago

  • Status changed from Ready For Testing to Closed

merged and changed commit msg to fixes #8442 - add eager loading of users on audit show page for history tab

#6 Updated by Shlomi Zadok almost 7 years ago

  • Status changed from Closed to New

Weird enough, https://github.com/theforeman/foreman/pull/1953/files and https://github.com/theforeman/foreman/pull/1964 should have cover this issue (which was tested by Ori and me) and now there is a regression.
re-opening (and fixing...)

#7 Updated by Shlomi Zadok almost 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2040 added
  • Pull request deleted (https://github.com/theforeman/foreman/pull/1964)

#8 Updated by Shlomi Zadok almost 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#9 Updated by Dominic Cleal almost 7 years ago

  • Assignee changed from Shlomi Zadok to Joseph Magen

Also available in: Atom PDF