Project

General

Profile

Refactor #8463

Remove gettext_i18n_rails_js from runtime dependencies

Added by Dominic Cleal over 7 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Packaging
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

gettext_i18n_rails_js is currently listed in bundler.d/i18n.rb (and assets.rb) which makes it a runtime dependency, but I don't think it needs to be. It only provides two things: rake tasks (and parsers), and assets which are precompiled.

gettext_i18n_rails_js should be in the assets + development groups only, so it's included when we precompile assets and again for developers who need those rake tasks to build locale files. Ensure that lib/tasks/gettext.rake is updated so it handles the gem being missing when it requires gettext_i18n_rails_js/tasks.

I'd probably suggest rearranging the i18n group a bit and moving fast_gettext, gettext_i18n_rails and i18n_data (see also #8462) to Gemfile as they're required deps, it's not an optional feature - then i18n.rb can be deleted.


Related issues

Related to Foreman - Bug #8462: Remove or use i18n_data dependencyClosed2014-11-20

Associated revisions

Revision 06a8693a (diff)
Added by Dominic Cleal over 7 years ago

refs #8463 - no longer package i18n.rb

Revision 6f6c0b3a (diff)
Added by Dominic Cleal over 7 years ago

fixes #8463 - remove i18n bundler group as it isn't optional

fast_gettext/gettext_i18n_rails are both runtime dependencies, not optional.
gettext_i18n_rails_js moved to assets as it provides no runtime functionality.

Revision 2e4037e2 (diff)
Added by Dominic Cleal over 7 years ago

refs #8463 - update reqs to match removing i18n bundler group

History

#1 Updated by Dominic Cleal over 7 years ago

  • Related to Bug #8462: Remove or use i18n_data dependency added

#2 Updated by Dominic Cleal over 7 years ago

fast_gettext: Gemfile
gettext: development.rb? I think it's only used in gettext_i18n_rails's rake tasks.
gettext_i18n_rails: Gemfile
gettext_i18n_rails_js: assets.rb
i18n_data: delete (#8462)
locale: development.rb? It's a dep of gettext.

#3 Updated by Dominic Cleal over 7 years ago

  • Status changed from New to Assigned
  • Assignee set to Dominic Cleal

#4 Updated by The Foreman Bot over 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1981 added
  • Pull request deleted ()

#5 Updated by Dominic Cleal over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Dominic Cleal over 7 years ago

  • Legacy Backlogs Release (now unused) set to 28

Also available in: Atom PDF