Project

General

Profile

Refactor #8503

Update ruby_parser and safemode gems

Added by Shlomi Zadok over 7 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Templates
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

It seems that ruby_parser version > 3.1.1 is breaking with latest safemode (1.2.1)
The issue may be with safemode gem
(tried running:

ruby ~/.rvm/gems/ruby-2.0.0-p576/gems/safemode-1.2.1/demo.rb 
)
and got:
Safemode doesn't allow to access 'constant' on Encoding (Safemode::SecurityError)

which is also breaking our tests when using ruby_parser version 3.6.3

Associated revisions

Revision ae5fc840 (diff)
Added by Dominic Cleal over 7 years ago

fixes #8503 - remove ruby_parser pin to allow safemode update

Revision 9b8f243e (diff)
Added by Dominic Cleal over 7 years ago

refs #8503 - remove ruby_parser pin

History

#1 Updated by Dominic Cleal over 7 years ago

  • Category set to Templates

#2 Updated by Dmitri Dolguikh over 7 years ago

  • Status changed from New to Ready For Testing

#3 Updated by The Foreman Bot over 7 years ago

  • Pull request https://github.com/theforeman/foreman/pull/2027 added
  • Pull request deleted ()

#4 Updated by Dominic Cleal over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Dominic Cleal over 7 years ago

  • Legacy Backlogs Release (now unused) set to 28

Also available in: Atom PDF