Project

General

Profile

Bug #8546

New ENC output for iinterfaces clashes with Facter

Added by Greg Sutcliffe over 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Facts
Target version:
Difficulty:
trivial
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Because we added params['interfaces'] to the ENC, we overwrite $::interfaces from Puppet's point of view. This could have consequences for people using $::interfaces in their puppet code.

Proposal for a quick fix is to namespace it to params['foreman_interfaces'] (and subnets too, for consistency).

Patch incoming, thanks to Shaun Martin for reporting


Related issues

Related to Foreman - Feature #2089: Expose network configuration via ENCClosed2013-01-02

Associated revisions

Revision d3b7f426 (diff)
Added by Greg Sutcliffe over 4 years ago

Fixes #8546 - Namespace interfaces and subnets to avoid a facts clash

Revision b18b21d3 (diff)
Added by Greg Sutcliffe over 4 years ago

Fixes #8546 - Namespace interfaces and subnets to avoid a facts clash

(cherry picked from commit d3b7f426959b7195ceedac1b9e719bfd1563af02)

History

#1 Updated by The Foreman Bot over 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1993 added
  • Pull request deleted ()

#2 Updated by Dominic Cleal over 4 years ago

  • Legacy Backlogs Release (now unused) set to 29

#3 Updated by Dominic Cleal over 4 years ago

  • Related to Feature #2089: Expose network configuration via ENC added

#4 Updated by Greg Sutcliffe over 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF