Project

General

Profile

Bug #8675

rubocop does not ignore engines/bastion_katello/node_modules/ files

Added by Justin Sherrill over 8 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Tests
Target version:
Difficulty:
trivial
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

es.rb:4:1: C: Extra empty line detected at body beginning.
engines/bastion_katello/node_modules/bastion/config/routes.rb:12:42: W: Unused block argument - name. If it's necessary, use _ or _name as an argument name to indicate that it won't be used.
pages = Bastion.plugins.collect { |name, plugin| plugin[:pages] }
^^^
engines/bastion_katello/node_modules/bastion/config/routes.rb:15:1: C: Extra empty line detected at body end.
engines/bastion_katello/node_modules/bastion/lib/bastion.rb:4:1: C: Favor if over unless for negative conditions.
require lib_foreman unless !Dir.exist?(lib_foreman)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
^
engines/bastion_katello/node_modules/bastion/lib/bastion.rb:12:1: C: Extra empty line detected at body beginning.
engines/bastion_katello/node_modules/bastion/lib/bastion.rb:13:3: C: Replace class var @plugins with a class instance var.
@plugins = {};
^^^^^^^
engines/bastion_katello/node_modules/bastion/lib/bastion.rb:13:17: C: Do not use semicolons to terminate expressions.
@@plugins = {};
^
engines/bastion_katello/node_modules/bastion/lib/bastion.rb:22:1: C: Extra empty line detected at body end.
engines/bastion_katello/node_modules/bastion/lib/bastion/engine.rb:5:1: C: Extra empty line detected at body beginning.
engines/bastion_katello/node_modules/bastion/lib/bastion/engine.rb:40:1: C: Extra empty line detected at body end.

Associated revisions

Revision d34fd064 (diff)
Added by Justin Sherrill over 8 years ago

fixes #8675 - updating rubocop.yml for bastion_katello

Revision e70c3270
Added by Justin Sherrill over 8 years ago

Merge pull request #4869 from jlsherrill/8675

fixes #8675 - updating rubocop.yml for bastion_katello

History

#1 Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/4869 added
  • Pull request deleted ()

#2 Updated by Justin Sherrill over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Eric Helms about 8 years ago

  • Legacy Backlogs Release (now unused) set to 23

Also available in: Atom PDF