Project

General

Profile

Refactor #8721

Replace all uses of jQuery(item).attr('id') with item.id

Added by Tomer Brisker over 7 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Performance
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

No need to use jQuery when we don't have to.
Using plain item.id is about 100X faster:
http://jsperf.com/jquery-item-attr-id-vs-item-id

Associated revisions

Revision 8cb120ea (diff)
Added by Tomer Brisker over 7 years ago

Fixes #8721 - Replaced jQuery.attr('id') with .id

History

#1 Updated by The Foreman Bot over 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2020 added
  • Pull request deleted ()

#2 Updated by Anonymous over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal over 7 years ago

  • Legacy Backlogs Release (now unused) set to 28

Also available in: Atom PDF