Project

General

Profile

Bug #878

Wget failed processes won't stop

Added by Marcello de Sousa over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
TFTP
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

After testing it for a while I get a collection of open "wget ..." processes. If wget fails, the processes are not closed and they are also not killed by the restart of the foreman-proxy daemon.

Posted patch:

---
 lib/proxy/tftp.rb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/proxy/tftp.rb b/lib/proxy/tftp.rb index f4b75b9..aea5d59 100644
--- a/lib/proxy/tftp.rb
+++ b/lib/proxy/tftp.rb
@@ -57,7 +57,7 @@ module Proxy::TFTP
       #as the dst might contain another sub directory
       FileUtils.mkdir_p destination.parent

-      cmd = "wget --no-check-certificate -nv -c #{src} -O \"#{destination}\"" 
+      cmd = "wget --timeout=10 --tries=3 --no-check-certificate -nv -c #{src} -O \"#{destination}\"" 
       Proxy::Util::CommandTask.new(cmd)
     end

--
1.7.4.1

Associated revisions

Revision 03e5b521 (diff)
Added by Marcello de Sousa over 9 years ago

fixes #878 - Include wget limits for timeout and retries.

Signed-off-by: Marcello de Sousa <>

History

#1 Updated by Anonymous over 9 years ago

  • Status changed from New to Ready For Testing
  • % Done changed from 0 to 100

#2 Updated by Ohad Levy over 9 years ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF