Project

General

Profile

Refactor #8797

Separate style from the HTML in emails.

Added by Shimon Shtein over 5 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
E-Mail
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Email templates contain style information inside the HTML.
It creates clutter in the erb files, and is difficult to track down when changing system style.
Consider using CSS to inline formatter, for example: [[https://www.ruby-toolbox.com/categories/Inline_CSS_for_E-Mail]]


Related issues

Related to Katello - Refactor #12403: Separate style from HTML in e-mailsNew2015-11-05
Related to Foreman - Refactor #15847: URL helpers must be used in mailersClosed2016-07-27

Associated revisions

Revision a1506cab (diff)
Added by Amir Fefer about 4 years ago

Fixes #8797 - Separate style from the HTML in emails

By using roadie-rails gem (1.1) style can be separated from email
html foramt, and absolute paths can be used.
style was separated to 'email.css'

Revision 58c396fa (diff)
Added by Dominic Cleal about 4 years ago

refs #8797 - require roadie-rails

History

#1 Updated by Shimon Shtein over 5 years ago

Forgot to mension an example file: app/views/audit_mailer/summary.html.erb

#2 Updated by Dominic Cleal over 5 years ago

  • Category set to E-Mail

#3 Updated by Amir Fefer almost 5 years ago

  • Assignee set to Amir Fefer

#4 Updated by The Foreman Bot almost 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2887 added

#5 Updated by Stephen Benjamin almost 5 years ago

#6 Updated by Dominic Cleal about 4 years ago

  • Legacy Backlogs Release (now unused) set to 160

#7 Updated by Amir Fefer about 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#8 Updated by Dominic Cleal about 4 years ago

Also available in: Atom PDF