Project

General

Custom queries

Profile

Actions
Copy link

Refactor #8797

closed

Separate style from the HTML in emails.

Added by Shimon Shtein over 10 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Amir Fefer
Category:
E-Mail
Target version:
1.13.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/2887
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Email templates contain style information inside the HTML.
It creates clutter in the erb files, and is difficult to track down when changing system style.
Consider using CSS to inline formatter, for example: [[https://www.ruby-toolbox.com/categories/Inline_CSS_for_E-Mail]]

Related issues 2 (1 open — 1 closed)

Related to Katello - Refactor #12403: Separate style from HTML in e-mailsNewActions
Related to Foreman - Refactor #15847: URL helpers must be used in mailersClosedDominic Cleal07/27/2016Actions
#2

Updated by Dominic Cleal over 10 years ago

  • Category set to E-Mail
#3

Updated by Amir Fefer over 9 years ago

  • Assignee set to Amir Fefer
#4

Updated by The Foreman Bot over 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2887 added
#5

Updated by Stephen Benjamin over 9 years ago

#6

Updated by Dominic Cleal almost 9 years ago

  • Translation missing: en.field_release set to 160
#7

Updated by Amir Fefer almost 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
#8

Updated by Dominic Cleal almost 9 years ago

Actions
Copy link

Also available in: Atom PDF