Project

General

Profile

Bug #8799

On host edit page, overriding inherited parameters removes override button.

Added by Tomer Brisker almost 5 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Removing the overriden value does not bring it back.
Puppetclass parameters work correctly.


Related issues

Related to Foreman - Tracker #10467: Parameter UI improvements in host and hostgroup formsNew2015-05-11

Blocked by Foreman - Refactor #11458: Allow overriding parameters inline in host & hostgroup formsClosed2015-08-24

Associated revisions

Revision 94344e68 (diff)
Added by Tomer Brisker about 4 years ago

Fixes #8799 - Show override button when removing overriden global param

Previously, when removing an override for an existing parameter the
override button was not displayed again until the page was reloaded.
Also saved call to `mark_params_override()` when overriding a single
parameter since we already know which row needs to be marked as
overriden, and used some css to simplify `mark_params_override()`.

Note this code will be rendered useless once global parameters are
turned into lookup keys as they will use the same inline-editing
available for lookup keys, however until that change is made this will
improve usability of global parmeter overrides.

History

#1 Updated by Tomer Brisker over 4 years ago

  • Related to Refactor #11458: Allow overriding parameters inline in host & hostgroup forms added

#2 Updated by Tomer Brisker over 4 years ago

  • Related to Tracker #10467: Parameter UI improvements in host and hostgroup forms added

#3 Updated by Tomer Brisker over 4 years ago

  • Related to deleted (Refactor #11458: Allow overriding parameters inline in host & hostgroup forms)

#4 Updated by Tomer Brisker over 4 years ago

  • Blocked by Refactor #11458: Allow overriding parameters inline in host & hostgroup forms added

#5 Updated by The Foreman Bot about 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tomer Brisker
  • Pull request https://github.com/theforeman/foreman/pull/2927 added

#6 Updated by Anonymous about 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#7 Updated by Dominic Cleal about 4 years ago

  • Category set to Web Interface
  • Legacy Backlogs Release (now unused) set to 71

Also available in: Atom PDF