Project

General

Profile

Bug #8821

Openstack images form fails for unnamed images

Added by Daniel Lobato Garcia almost 5 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Compute resources - OpenStack
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

The images helper looks for a .name attribute in all fog images in Openstack. However, it's possible to create images just with an ID and without a name (there is currently one in OS1 private). The form will fail with "undefined method `downcase' for nil:NilClass" for that image as it cannot find its name.

Just defaulting to the id of the image if the name is not available should be enough.

Associated revisions

Revision 8aae72f7 (diff)
Added by Daniel Lobato Garcia over 4 years ago

Fixes #8821 - Handle unnamed OpenStack images in images form

Revision b3fdf2bb (diff)
Added by Daniel Lobato Garcia over 4 years ago

Fixes #8821 - Handle unnamed OpenStack images in images form

(cherry picked from commit 8aae72f7521a387a797038b2902eb09ca1ab13a7)

History

#1 Updated by Dominic Cleal almost 5 years ago

  • Category set to Compute resources - OpenStack

#2 Updated by The Foreman Bot almost 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2044 added
  • Pull request deleted ()

#3 Updated by Dominic Cleal over 4 years ago

  • Legacy Backlogs Release (now unused) set to 30

#4 Updated by Daniel Lobato Garcia over 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF