Project

General

Profile

Actions

Feature #8854

closed

Allow creation of DHCP records without IP specified

Added by Lukas Zapletal over 9 years ago. Updated almost 3 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
DHCP
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

For automated deployments API users do unused_ip followed by DHCP record creation for the IP returned. By making "ip" parameter optional in the POST /dhcp/network call we can do the unused_ip call in proxy to shorten the timeframe between IP is picked up and reservation.

We've seen conflicts in Staypuft/OpenStack setups and this little change can prevent that.

Also this change would be useful in core Foreman - we would not need to have IP address a mandatory field in the New Host (bare-metal) form. If it's empty, we could simply send the reservation request without any IP to get one. Currently, the call returns the record created, therefore we'd only need to store the IP from reservation with the host entry.

Actions #1

Updated by Dominic Cleal over 9 years ago

Just a couple of corrections, the IP field is optional in many circumstances in Foreman, not mandatory. Both API and UI should request an IP from the smart proxy if it's not supplied and the subnet can supply one, before validation and orchestration occurs - no separate unused_ip call should be required for a user of the Foreman API as it stands.

I can see what you mean about doing this within the DHCP reservation step on the proxy, but you'll have to contend with a lot of changes to validation in Foreman, as other orchestration steps may depend on having an IP address available, and you also won't have the IP address at validation time (or any indication if an IP is even available).

Be careful!

Actions #2

Updated by Lukas Zapletal almost 3 years ago

  • Status changed from New to Rejected

We now have a locking mechanism, this is not needed.

Actions

Also available in: Atom PDF