Bug #8874: gettext 3.1.13+ causes locale tx-update errors due to .edit.po files - Foreman

Actions

Copy link

Bug #8874

closed

gettext 3.1.13+ causes locale tx-update errors due to .edit.po files

Added by Dominic Cleal about 10 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Dominic Cleal

Category:

Internationalization

Target version:

1.11.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/2096, https://github.com/theforeman/foreman_discovery/pull/244

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Since gettext 3.1.13+ locale updates aren't working quite right, as some new .edit.po and timestamp files in the locale directories are created, which breaks the git commits in our Makefile.

The intention appears to be that we pull translations into the .edit.po files instead, which get merged into the .po files by gettext.

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Dominic Cleal about 10 years ago

Previously...

make -C locale tx-update
- pulls rails locale files
- runs tx pull, which overwrites locale/*/foreman.po
- git commits
- runs rake locale:po_to_json, which converts foreman.po to app.js
- runs rake locale:find, which overwrites locale/foreman.po, re-merges locale/*/foreman.po
- reverts locale/*/foreman.po from previous step
- git amends

Now there's an .edit.po and real .po file, tx pull should in theory go to the edit file first, then let gettext handle merging back to .po.

Actions

Copy link

Updated by Dominic Cleal about 10 years ago

I opened https://github.com/ruby-gettext/gettext/issues/36 to ask for examples or help on what the .edit.po is for, and how it should be used before deciding exactly how to proceed.

Actions

Copy link

Updated by Anonymous about 10 years ago

Related to Tracker #8978: Drop Ruby 1.8 support in hammer added

Actions

Copy link

Updated by The Foreman Bot about 10 years ago

Status changed from Assigned to Ready For Testing
Pull request https://github.com/theforeman/foreman/pull/2096 added
Pull request deleted ()

Actions

Copy link

Updated by Dominic Cleal about 10 years ago

Now:

make -C locale tx-update
- pulls rails locale files
- runs rake locale:find, which updates foreman.pot, generates .po and .edit.po files
- runs tx pull, which overwrites locale/*/foreman.edit.po
- runs rake locale:find, which merges into locale/*/foreman.po
- runs rake locale:po_to_json, which converts foreman.po to app.js
- git commits