Project

General

Profile

Bug #9049

Swallowed exception message when triggering a Puppet run

Added by Jiri Stransky over 4 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Puppet integration
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

If an exception occurs during triggering a Puppet run from the UI,
user will be notified of the error in a flash message. If the
exception occurs when running the action non-interactively (e.g. from
a DynFlow task), the exception will get swallowed.

The issue stands in the way of further debugging of a Staypuft issue:

https://bugzilla.redhat.com/show_bug.cgi?id=1183802

Associated revisions

Revision 86adb030 (diff)
Added by Jiri Stransky over 4 years ago

Fixes #9049 - Log exceptions when triggering a Puppet run

If an exception occurs during triggering a Puppet run from the UI,
user will be notified of the error in a flash message. If the
exception occurs when running the action non-interactively (e.g. from
a DynFlow task), the exception will get swallowed. This patch makes
sure the exception message is at least logged to allow later
inspection.

The patch is necessary to proceed with debugging of a Staypuft issue:

https://bugzilla.redhat.com/show_bug.cgi?id=1183802

Revision e9672724 (diff)
Added by Jiri Stransky over 4 years ago

Refs #9049 - fix log message formatting

Missing "%s" in the commit that was supposed to fix #9049 caused the
exception message not to be printed into the log.

Revision 7a97233d (diff)
Added by Jiri Stransky over 4 years ago

Fixes #9049 - Log exceptions when triggering a Puppet run

If an exception occurs during triggering a Puppet run from the UI,
user will be notified of the error in a flash message. If the
exception occurs when running the action non-interactively (e.g. from
a DynFlow task), the exception will get swallowed. This patch makes
sure the exception message is at least logged to allow later
inspection.

The patch is necessary to proceed with debugging of a Staypuft issue:

https://bugzilla.redhat.com/show_bug.cgi?id=1183802
(cherry picked from commit 86adb030eafdc37658b02d6dad5b1ff6e94d4bcf)

Revision ad822960 (diff)
Added by Jiri Stransky over 4 years ago

Refs #9049 - fix log message formatting

Missing "%s" in the commit that was supposed to fix #9049 caused the
exception message not to be printed into the log.

(cherry picked from commit e9672724ef29fc2db401e05aa89eacc2c06c51a7)

History

#1 Updated by Dominic Cleal over 4 years ago

  • Category set to Puppet integration
  • Status changed from New to Ready For Testing
  • Assignee set to Jiri Stransky
  • Pull request https://github.com/theforeman/foreman/pull/2100 added
  • Pull request deleted ()

#2 Updated by Dominic Cleal over 4 years ago

  • Legacy Backlogs Release (now unused) set to 30

#3 Updated by Jiri Stransky over 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF