Project

General

Profile

Refactor #9063

Revert pinning of Rack to < 1.6

Added by Dominic Cleal almost 6 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Packaging
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

#9061 pinned Rack to < 1.6 due to an interaction with Sinatra: https://github.com/sinatra/sinatra/issues/951

Revert this once a new Sinatra release is out.


Related issues

Related to Smart Proxy - Bug #9061: Tests fail with NoMethodError: undefined method `join' for #<String:0x007f62c3e6fb90>Closed2015-01-21

Associated revisions

Revision 39545f9c (diff)
Added by Michael Moll almost 4 years ago

Fixes #9063 - Revert pinning of Rack to < 1.6

History

#1 Updated by Dominic Cleal almost 6 years ago

  • Related to Bug #9061: Tests fail with NoMethodError: undefined method `join' for #<String:0x007f62c3e6fb90> added

#2 Updated by Dmitri Dolguikh about 5 years ago

looks like in rack versions > 1.6 and < 1.6.4 an issue was introduced that prevents it from running on ruby 1.8.7. rack 1.6.5 should resolve this when it's released.

#3 Updated by Dmitri Dolguikh about 5 years ago

See https://github.com/rack/rack/commit/2fd9df71aff4af8a3ab8088a6919f5d9a5e4ab95 is the commit that re-introduces 1.8.7 support.

#4 Updated by The Foreman Bot almost 4 years ago

  • Assignee set to Anonymous
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/503 added

#5 Updated by Anonymous almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 209

Also available in: Atom PDF