Project

General

Profile

Actions
Copy link

Refactor #9063

closed

Revert pinning of Rack to < 1.6

Added by Dominic Cleal almost 10 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Packaging
Target version:
1.15.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/smart-proxy/pull/503
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

#9061 pinned Rack to < 1.6 due to an interaction with Sinatra: https://github.com/sinatra/sinatra/issues/951

Revert this once a new Sinatra release is out.

Related issues 1 (0 open — 1 closed)

Related to Smart Proxy - Bug #9061: Tests fail with NoMethodError: undefined method `join' for #<String:0x007f62c3e6fb90>Closed01/21/2015Actions
Actions
Copy link
 #1

Updated by Dominic Cleal almost 10 years ago

  • Related to Bug #9061: Tests fail with NoMethodError: undefined method `join' for #<String:0x007f62c3e6fb90> added
Actions
Copy link
 #2

Updated by Anonymous about 9 years ago

looks like in rack versions > 1.6 and < 1.6.4 an issue was introduced that prevents it from running on ruby 1.8.7. rack 1.6.5 should resolve this when it's released.

Actions
Copy link
 #3

Updated by Anonymous about 9 years ago

See https://github.com/rack/rack/commit/2fd9df71aff4af8a3ab8088a6919f5d9a5e4ab95 is the commit that re-introduces 1.8.7 support.

Actions
Copy link
 #4

Updated by The Foreman Bot almost 8 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Anonymous
  • Pull request https://github.com/theforeman/smart-proxy/pull/503 added
Actions
Copy link
 #5

Updated by Anonymous almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #6

Updated by Dominic Cleal almost 8 years ago

  • Translation missing: en.field_release set to 209
Actions
Copy link

Also available in: Atom PDF