Project

General

Profile

Actions

Bug #9097

closed

Typo in value_to_sql method causes ext_method searches with LIKE to not be applied

Added by David Davis over 9 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Search
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Found a bug here:

https://github.com/theforeman/foreman/blob/ee1f56de6b2bdca4dfd104b99ec25340bfb51aaa/app/models/concerns/scoped_search_extensions.rb#L7

I believe that should be ~= instead of ~. The reason we're not seeing any bugs? Looks like it's being rescued here:

https://github.com/wvanbergen/scoped_search/blob/v2.7.1/lib/scoped_search/query_builder.rb#L371

To test, I think this should reproduce the problem:

1. Create a host
2. Try to filter by one of the affected search scopes (e.g. 'user_id = 999999'). Make sure you use '=' in your search.

Your host should still be visible when it ought not to be.

Actions #1

Updated by David Davis over 9 years ago

s/~=/=~/

Actions #2

Updated by David Davis over 9 years ago

Actually, here are the fixed steps to reproduce:

1. Create a host
2. Try to filter by one of the affected search scopes (e.g. 'user.firstname = nonexitent_name'). Make sure you use '=' in your search.

Actions #3

Updated by David Davis over 9 years ago

  • Status changed from New to Closed

Can't reproduce.

Actions #4

Updated by David Davis over 9 years ago

  • Status changed from Closed to New

eLobato found the commit which shows it should be =~ as the code was moved:

https://github.com/theforeman/foreman/commit/e44f5c1c08d3f332b13fadd442dd754597db2b90

Actions #5

Updated by David Davis over 9 years ago

Actually, in the steps to reproduce it should be "~" and not "=". Here are the steps:

1. Create a host
2. Go to the hosts page and search on "user.firstname ~ dfsjklfdsjlk" or some first name that doesn't exist.

Your host will be visible even though it shouldn't be.

Actions #6

Updated by The Foreman Bot over 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2105 added
  • Pull request deleted ()
Actions #7

Updated by David Davis over 9 years ago

  • Subject changed from Found a bug in the code to Typo in value_to_sql method causes ext_method searches with LIKE to not be applied
Actions #8

Updated by Dominic Cleal over 9 years ago

  • Assignee set to David Davis
Actions #9

Updated by David Davis over 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #10

Updated by Dominic Cleal over 9 years ago

  • Translation missing: en.field_release set to 30
Actions

Also available in: Atom PDF