Bug #9097
closed
Typo in value_to_sql method causes ext_method searches with LIKE to not be applied
Description
Found a bug here:
I believe that should be ~= instead of ~. The reason we're not seeing any bugs? Looks like it's being rescued here:
https://github.com/wvanbergen/scoped_search/blob/v2.7.1/lib/scoped_search/query_builder.rb#L371
To test, I think this should reproduce the problem:
1. Create a host
2. Try to filter by one of the affected search scopes (e.g. 'user_id = 999999'). Make sure you use '=' in your search.
Your host should still be visible when it ought not to be.
Updated by David Davis about 9 years ago
Actually, here are the fixed steps to reproduce:
1. Create a host
2. Try to filter by one of the affected search scopes (e.g. 'user.firstname = nonexitent_name'). Make sure you use '=' in your search.
Updated by David Davis about 9 years ago
- Status changed from Closed to New
eLobato found the commit which shows it should be =~ as the code was moved:
https://github.com/theforeman/foreman/commit/e44f5c1c08d3f332b13fadd442dd754597db2b90
Updated by David Davis about 9 years ago
Actually, in the steps to reproduce it should be "~" and not "=". Here are the steps:
1. Create a host
2. Go to the hosts page and search on "user.firstname ~ dfsjklfdsjlk" or some first name that doesn't exist.
Your host will be visible even though it shouldn't be.
Updated by The Foreman Bot about 9 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/2105 added
- Pull request deleted (
)
Updated by David Davis about 9 years ago
- Subject changed from Found a bug in the code to Typo in value_to_sql method causes ext_method searches with LIKE to not be applied
Updated by David Davis about 9 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset e86494a89e3b7f71850b6582be4d05b7badaab21.
Updated by Dominic Cleal about 9 years ago
- translation missing: en.field_release set to 30