Project

General

Profile

Actions
Copy link

Refactor #9142

closed

Unify validate_regexp and validate_list for lookup value/key

Added by Daniel Lobato Garcia almost 10 years ago. Updated over 9 years ago.

Status:
Duplicate
Priority:
Normal
Assignee:
-
Category:
Parameters
Target version:
-
Difficulty:
Triaged:
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

There is some 100% duplicated code in lookup value/key that should be DRYed as soon as possible, perhaps take out such logic to a concern about validating ERB.

https://github.com/theforeman/foreman/pull/2080/files#r23497738 <- take into account if you're fixing this.

Related issues 2 (0 open — 2 closed)

Related to Foreman - Bug #8052: Smart class parameters with ERB snippets are broken for other that String typesClosedMarek Hulán10/23/2014Actions
Is duplicate of Foreman - Refactor #10232: move validations and casting out of lookup keys and values into single-responsibility classesClosedTom Caspy04/22/2015Actions
Actions
Copy link
 #1

Updated by Dominic Cleal almost 10 years ago

  • Category set to Parameters
Actions
Copy link
 #2

Updated by Dominic Cleal almost 10 years ago

  • Related to Bug #8052: Smart class parameters with ERB snippets are broken for other that String types added
Actions
Copy link
 #3

Updated by Dominic Cleal over 9 years ago

  • Is duplicate of Refactor #10232: move validations and casting out of lookup keys and values into single-responsibility classes added
Actions
Copy link
 #4

Updated by Dominic Cleal over 9 years ago

  • Status changed from New to Duplicate

#10232 seems to have done this.

Actions
Copy link

Also available in: Atom PDF