Actions
Bug #9159
closedRubocop 0.28 failures
Description
Tests are failing on foreman-docker currently due to new rubocop I guess:
00:14:11.675 Running RuboCop... 00:14:11.675 Inspecting 36 files 00:14:11.675 CCCC.C..C.C....C..CC...C.........C.. 00:14:11.675 00:14:11.675 Offenses: 00:14:11.675 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/helpers/containers_helper.rb:13:50: C: Align the operands of an expression in an assignment spanning multiple lines. 00:14:11.675 .pluck(:uuid) 00:14:11.675 ^^^^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/helpers/containers_helper.rb:36:3: C: Assignment Branch Condition size for container_title_actions is too high. [17.03/15] 00:14:11.675 def container_title_actions(container) 00:14:11.675 ^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/helpers/container_steps_helper.rb:11:7: C: Align the operands of an expression in an assignment spanning multiple lines. 00:14:11.675 .authorized(:view_registries) 00:14:11.675 ^^^^^^^^^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/controllers/concerns/foreman_docker/find_container.rb:12:29: C: Align the operands of an expression in an assignment spanning multiple lines. 00:14:11.675 .find(params[:id]) 00:14:11.675 ^^^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/controllers/registries_controller.rb:7:7: C: Align the operands of an expression in an assignment spanning multiple lines. 00:14:11.675 .paginate :page => params[:page] 00:14:11.675 ^^^^^^^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/controllers/containers_controller.rb:37:3: C: Assignment Branch Condition size for commit is too high. [21.05/15] 00:14:11.675 def commit 00:14:11.675 ^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/controllers/containers_controller.rb:45:42: C: Use 2 (not 21) spaces for indenting an expression spanning multiple lines. 00:14:11.675 { :container => @container } 00:14:11.675 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/controllers/containers_controller.rb:48:53: C: Use 2 (not 48) spaces for indenting an expression spanning multiple lines. 00:14:11.675 { :container => @container, :e => e } 00:14:11.675 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/controllers/containers_controller.rb:64:3: C: Assignment Branch Condition size for container_deletion is too high. [16.25/15] 00:14:11.675 def container_deletion 00:14:11.675 ^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/controllers/containers_controller.rb:74:7: C: Use 2 (not 0) spaces for indenting an expression spanning multiple lines. 00:14:11.675 @container.destroy 00:14:11.675 ^^^^^^^^^^^^^^^^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/controllers/containers_controller.rb:80:42: C: Align the operands of an expression in an assignment spanning multiple lines. 00:14:11.675 .find(resource_id) 00:14:11.675 ^^^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/models/docker_container_wizard_states/environment_variable.rb:4:16: C: Align the elements of a hash literal if they span more than one line. 00:14:11.675 :class_name => 'DockerContainerWizardStates::Environment' 00:14:11.675 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/models/docker_container_wizard_states/environment.rb:10:14: C: Align the elements of a hash literal if they span more than one line. 00:14:11.675 :inverse_of => :environment, 00:14:11.675 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/models/docker_container_wizard_states/environment.rb:11:14: C: Align the elements of a hash literal if they span more than one line. 00:14:11.675 :class_name => 'DockerContainerWizardStates::EnvironmentVariable', 00:14:11.675 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/models/docker_container_wizard_states/environment.rb:12:14: C: Align the elements of a hash literal if they span more than one line. 00:14:11.675 :validate => false 00:14:11.675 ^^^^^^^^^^^^^^^^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/models/docker_container_wizard_state.rb:3:11: C: Align the elements of a hash literal if they span more than one line. 00:14:11.675 :dependent => :destroy, :validate => true, :autosave => true 00:14:11.675 ^^^^^^^^^^^^^^^^^^^^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/models/docker_container_wizard_state.rb:5:11: C: Align the elements of a hash literal if they span more than one line. 00:14:11.675 :dependent => :destroy, :validate => true, :autosave => true 00:14:11.675 ^^^^^^^^^^^^^^^^^^^^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/models/docker_container_wizard_state.rb:7:11: C: Align the elements of a hash literal if they span more than one line. 00:14:11.675 :dependent => :destroy, :validate => true, :autosave => true 00:14:11.675 ^^^^^^^^^^^^^^^^^^^^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/models/docker_container_wizard_state.rb:9:11: C: Align the elements of a hash literal if they span more than one line. 00:14:11.675 :dependent => :destroy, :validate => true, :autosave => true 00:14:11.675 ^^^^^^^^^^^^^^^^^^^^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/models/docker_container_wizard_state.rb:14:3: C: Assignment Branch Condition size for container_attributes is too high. [28/15] 00:14:11.675 def container_attributes 00:14:11.675 ^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/models/service/containers.rb:7:5: C: Assignment Branch Condition size for start_container! is too high. [23.17/15] 00:14:11.675 def start_container!(wizard_state) 00:14:11.675 ^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/models/service/containers.rb:12:13: C: Align the operands of an expression in an assignment spanning multiple lines. 00:14:11.675 .find(wizard_state.id) 00:14:11.675 ^^^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/app/models/container.rb:24:3: C: Assignment Branch Condition size for parametrize is too high. [17/15] 00:14:11.675 def parametrize 00:14:11.675 ^^^ 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/lib/foreman_docker/engine.rb:80:1: C: Extra empty line detected at block body end. 00:14:11.675 /var/lib/workspace/workspace/test_plugin/plugin/test/units/containers_service_test.rb:21:39: C: Use 2 (not 34) spaces for indenting an expression spanning multiple lines. 00:14:11.675 .returns(OpenStruct.new(:uuid => 1)) 00:14:11.675 ^^^^^^^^ 00:14:11.675 00:14:11.675 36 files inspected, 25 offenses detected
Updated by Dominic Cleal over 9 years ago
- Related to Bug #9099: Upgrade to rubocop 0.28 added
Updated by The Foreman Bot over 9 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman-docker/pull/73 added
- Pull request deleted (
)
Updated by David Davis over 9 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset foreman-docker|ac230210a5d69c663012c45b6531c4f2bb1dc3ff.
Actions