Project

General

Profile

Bug #9187

Overrideable empty puppet class parameters are still validate their default value

Added by Ewoud Kohl van Wijngaarden about 8 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ori Rabin
Category:
Parameters
Target version:
1.9.0
Difficulty:
Triaged:
Bugzilla link:
1229404
Pull request:
https://github.com/theforeman/foreman/pull/2408
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

As promised at dinner last night here is the issue :)

With #3260 it became possible to have puppet class parameters that are overrideable but they still validate their default value. That means a parameter with a default value of ${puppet::params::server} and of type boolean will error out even though the default value is not used.

Related issues

Related to Foreman - Feature #3260: Allow puppet parameters to have no default value, but overrideableClosed2013-10-15
Related to Foreman - Bug #9812: 'match' and 'value' parameters in override value's create should be required in apidocClosed2015-03-18
Related to Foreman - Bug #11663: Empty lookup value validated even when use_puppet_default is checkedClosed2015-09-02
Has duplicate Foreman - Bug #12878: Default Puppet parameter from Satellite is still validated if "Use Puppet default" is selectedDuplicate2015-12-18

Associated revisions

Revision 92eb3d7c (diff)
Added by Ori Rabin almost 8 years ago

Fixes #9187 - Overrideable empty class parameters don't validate default value

History

#1 Updated by Ewoud Kohl van Wijngaarden about 8 years ago

  • Related to Feature #3260: Allow puppet parameters to have no default value, but overrideable added

#2 Updated by Dominic Cleal about 8 years ago

  • Category set to Parameters

#3 Updated by Ewoud Kohl van Wijngaarden about 8 years ago

For other users: the workaround is to uncheck the 'use puppet default' checkbox, set a valid default, save, uncheck the checkbox and save again.

#4 Updated by Dominic Cleal almost 8 years ago

  • Related to Bug #9812: 'match' and 'value' parameters in override value's create should be required in apidoc added

#5 Updated by Dominic Cleal almost 8 years ago

I think #9812 might have made this worse in some cases, as it checks for a value to be present...

#6 Updated by The Foreman Bot almost 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2408 added
  • Pull request deleted ()

#7 Updated by Dominic Cleal almost 8 years ago

  • Legacy Backlogs Release (now unused) set to 35

#8 Updated by Ori Rabin almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#9 Updated by Dominic Cleal over 7 years ago

  • Related to Bug #11663: Empty lookup value validated even when use_puppet_default is checked added

#10 Updated by Dominic Cleal over 7 years ago

  • Has duplicate Bug #12878: Default Puppet parameter from Satellite is still validated if "Use Puppet default" is selected added

#11 Updated by Bryan Kearney over 7 years ago

  • Bugzilla link set to 1229404

Also available in: Atom PDF