Project

General

Custom queries

Profile

Actions
Copy link

Bug #9187

closed

Overrideable empty puppet class parameters are still validate their default value

Added by Ewoud Kohl van Wijngaarden over 10 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ori Rabin
Category:
Parameters
Target version:
1.9.0
Difficulty:
Triaged:
Bugzilla link:
1229404
Pull request:
https://github.com/theforeman/foreman/pull/2408
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

As promised at dinner last night here is the issue :)

With #3260 it became possible to have puppet class parameters that are overrideable but they still validate their default value. That means a parameter with a default value of ${puppet::params::server} and of type boolean will error out even though the default value is not used.

Related issues 4 (0 open — 4 closed)

Related to Foreman - Feature #3260: Allow puppet parameters to have no default value, but overrideableClosedOri Rabin10/15/2013Actions
Related to Foreman - Bug #9812: 'match' and 'value' parameters in override value's create should be required in apidocClosedShlomi Zadok03/18/2015Actions
Related to Foreman - Bug #11663: Empty lookup value validated even when use_puppet_default is checkedClosedOri Rabin09/02/2015Actions
Has duplicate Foreman - Bug #12878: Default Puppet parameter from Satellite is still validated if "Use Puppet default" is selectedDuplicate12/18/2015Actions
Actions
Copy link
 #3

Updated by Ewoud Kohl van Wijngaarden about 10 years ago

For other users: the workaround is to uncheck the 'use puppet default' checkbox, set a valid default, save, uncheck the checkbox and save again.

Actions
Copy link
 #5

Updated by Dominic Cleal almost 10 years ago

I think #9812 might have made this worse in some cases, as it checks for a value to be present...

Actions
Copy link
 #8

Updated by Ori Rabin almost 10 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF