Project

General

Profile

Bug #9231

Exception message missing when ENC fails to render

Added by Dominic Cleal over 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
External Nodes
Target version:
Difficulty:
easy
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

From http://projects.theforeman.org/issues/9185#note-3, when the ENC fails to render, the exception message isn't logged:

Failed to generate external nodes for host4.cloud.example.com with

It appears that refactoring in 4f7a4d0ba84f43e3cb0d422d9f5e82b01588f21b changed the logging message to use $ERROR_INFO instead of $!. This variable is only available if the 'English' library is loaded, which it doesn't appear to be.


Related issues

Related to Foreman - Bug #9185: Deleting a network interface breaks all puppet agent syncingResolved2015-02-01
Related to Foreman - Feature #3809: Add rubocop to foremanClosed
Has duplicate Foreman - Bug #9305: ENC failures are not logged correctlyDuplicate2015-02-10

Associated revisions

Revision 350a0417 (diff)
Added by David Davis over 4 years ago

Fixes #9231 - Require English lib and fix ENC failure

Revision 904fb5a8 (diff)
Added by David Davis over 4 years ago

Fixes #9231 - Require English lib and fix ENC failure

(cherry picked from commit 350a0417951ebff465cda10645eae5c1dedae2cc)

History

#1 Updated by Dominic Cleal over 4 years ago

  • Related to Bug #9185: Deleting a network interface breaks all puppet agent syncing added

#2 Updated by Dominic Cleal over 4 years ago

#3 Updated by Dominic Cleal over 4 years ago

  • Difficulty set to easy

#4 Updated by Dominic Cleal over 4 years ago

There's another instance in app/models/host/managed.rb, so these either need reverting (and disable Style/SpecialGlobalVars in rubocop again) or require English from something core in config/.

#5 Updated by David Davis over 4 years ago

  • Assignee set to David Davis

#6 Updated by The Foreman Bot over 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2131 added
  • Pull request deleted ()

#7 Updated by Ohad Levy over 4 years ago

  • Has duplicate Bug #9305: ENC failures are not logged correctly added

#8 Updated by David Davis over 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#9 Updated by Dominic Cleal over 4 years ago

  • Legacy Backlogs Release (now unused) set to 32

Also available in: Atom PDF