Project

General

Profile

Actions

Bug #9286

closed

node.rb timeout is too low for some usecases and not configurable

Added by Jiri Stransky about 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

For some usecases catalog compilation might take a longer time, and when there's too many requests to Foreman and Passenger decides to handle the request from node.rb by a freshly spawned worker, node.rb can hit the time out, fail to send the catalog to the client, and the client's Puppet run ends with error.

The timeout is currently hardwired to 10 seconds in puppet-foreman. It should be configurable at least, and maybe raising the default should be considered (especially due to the fresh Passenger worker issue described above).

Blocks this BZ https://bugzilla.redhat.com/show_bug.cgi?id=1188704

Actions #1

Updated by Ewoud Kohl van Wijngaarden about 9 years ago

https://github.com/theforeman/puppet-foreman/blob/master/files/external_node_v2.rb#L38-L40 reads the timeout from the config (/etc/puppet/foreman.yaml) and only falls back to 10 if the :timeout value isn't found. That means it should be configurable, but it is true that foreman::puppetmaster can't configure it.

Actions #2

Updated by Jiri Stransky about 9 years ago

Yeah i found that, i should have expressed myself better -- what i meant was that the value is not configurable by puppet-foreman and therefore it's not configurable from foreman-installer's answer file. We use foreman-installer and we'd like to provide a higher default value for the parameter. I could do it with `sed` after foreman-installer finishes, but it would be cleaner to do this by pre-setting this parameter in the answer file.

Actions #3

Updated by Ewoud Kohl van Wijngaarden about 9 years ago

Fair enough.

Actions #4

Updated by Jiri Stransky about 9 years ago

I hope to have pull request(s) tomorrow.

Actions #5

Updated by Jiri Stransky about 9 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100
Actions #6

Updated by Dominic Cleal almost 9 years ago

  • translation missing: en.field_release set to 28
Actions

Also available in: Atom PDF