Project

General

Profile

Bug #9359

puppet_ca parameter made available for unmanaged hosts

Added by Chris Pisano over 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
External Nodes
Target version:
Difficulty:
easy
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Right now in order for the puppet_ca parameter to be made available unattended needs to be set to true and a host needs to be managed. Is it possible to change the check to allow the puppet_ca parameter to be made available for unmanaged hosts as well?


Related issues

Has duplicate Foreman - Feature #13060: Missing puppetca in YAML parametersDuplicate2016-01-08

Associated revisions

Revision f095f89d (diff)
Added by julien IPPOLITO over 3 years ago

fixes #9359 - display puppetca in yaml always when a puppetca is configured

Revision b9ee40b1 (diff)
Added by julien IPPOLITO over 3 years ago

fixes #9359 - display puppetca in yaml always when a puppetca is configured

(cherry picked from commit f095f89d5c6b15aab6ee2394fd30637b06287b5c)

History

#1 Updated by Dominic Cleal over 4 years ago

  • Category set to External Nodes
  • Difficulty set to easy

#2 Updated by Chris Pisano about 4 years ago

After reaching out in #theforeman-dev it seems like line 357 in

https://github.com/theforeman/foreman/blob/develop/app/models/host/managed.rb#L357

would need to be moved outside of the if block and placed where param["puppetmaster"] is. According to lines 53 - 62 in

https://github.com/theforeman/foreman/blob/develop/app/helpers/hosts_and_hostgroups_helper.rb#L53-L62

puppet_ca is only enabled if there is a proxy with the CA feature enabled. It seems like we wouldn't want puppet_ca to be displayed if it wasn't enabled. I'm not sure what to do with line 357 in managed.rb since :unattended doesn't seem to have a relation to the ca proxy feature.

#3 Updated by Dominic Cleal over 3 years ago

  • Has duplicate Feature #13060: Missing puppetca in YAML parameters added

#4 Updated by Chris Pisano over 3 years ago

  • Assignee set to Chris Pisano

#5 Updated by The Foreman Bot over 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3039 added

#6 Updated by Dominic Cleal over 3 years ago

  • Assignee changed from Chris Pisano to julien ippolito
  • Legacy Backlogs Release (now unused) set to 104

#7 Updated by Anonymous over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF