Project

General

Profile

Bug #9425

Remove Default user role which does not work

Added by Marek Hulán almost 6 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Users, Roles and Permissions
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

After permissions were migrated to filters, we do not copy filters from Default user role. See https://github.com/theforeman/foreman/blob/develop/app/controllers/roles_controller.rb#L28 and http://theforeman.org/manuals/1.7/index.html#4.1.2RolesandPermissions for more details. The fact I didn't find any bug report (it's broken since 1.5) means that either I didn't search long enough or no one is actually using it. So I'd like to know whether we should try to fix it or remove it as it seems quite confusing to me. Users can do similar tasks by using role cloning.


Related issues

Related to Foreman - Refactor #13896: Builtin Roles badly namedClosed2016-02-25
Related to Foreman - Refactor #994: The Role default_user is misleadingRejected2011-06-17

Associated revisions

Revision 4a4c48e1 (diff)
Added by Tomer Brisker almost 5 years ago

Fixes #9425 - Remove the Default User role

The Default User role is not actually used anywhere, and causes
confusion with the Anonymous role. Removing it.

History

#1 Updated by Dominic Cleal almost 6 years ago

Yeah, I can't see much point in keeping it. "Anonymous" is far more important.

#2 Updated by Marek Hulán almost 6 years ago

So I'll propose dropping this on user mailing list if there are no objections in several days, I'll change this to actually remove it.

#3 Updated by Marek Hulán almost 6 years ago

  • Subject changed from Default user role does not do what manual says to Remove Default user role which does not work

Noone objected so far, let's remove it (also from manual)

#4 Updated by The Foreman Bot almost 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tomer Brisker
  • Pull request https://github.com/theforeman/foreman/pull/3237 added

#5 Updated by Tomer Brisker almost 5 years ago

#6 Updated by Anonymous almost 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#7 Updated by Dominic Cleal almost 5 years ago

  • Legacy Backlogs Release (now unused) set to 136

#8 Updated by Dominic Cleal almost 5 years ago

  • Related to Refactor #994: The Role default_user is misleading added

Also available in: Atom PDF