Project

General

Profile

Refactor #9486

pool.rb lazy_accessor tech debt

Added by Thomas McKay over 4 years ago. Updated about 1 year ago.

Status:
Rejected
Priority:
Normal
Assignee:
Category:
-
Target version:
Branch:
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

File is overwhelmingly bad, having grown over the years into a big pile of crud. @jsherrill suggested updating things to properly use lazy_accessor. A lot of these attributes will/should move into the model directly for scoped search as well.

       lazy_accessor :remote_data, :pool_derived, :product_name, ...
                      :initializer => (lambda do |pool|
                        attributes = {}
                        pool.remote_data['attributes'].map do |attribute|
                          attributes[attribute[:name].camel_case] = attribute['value']
                        end
                      end)

History

#1 Updated by Eric Helms over 4 years ago

  • Tracker changed from Bug to Refactor
  • Legacy Backlogs Release (now unused) set to 31
  • Triaged changed from No to Yes

#2 Updated by Eric Helms over 4 years ago

  • Legacy Backlogs Release (now unused) deleted (31)

#3 Updated by Eric Helms almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 114

#4 Updated by Thomas McKay about 1 year ago

  • Status changed from Assigned to Rejected

Old issue, a lot changed since then

Also available in: Atom PDF