Project

General

Profile

Actions

Refactor #9553

closed

remove dump_in_quirks_mode

Added by Shlomi Zadok over 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

We have created a method that adds quirks_mode => true to JSON.dump
From json ~> 1.8, this option is built into JSON.dump method
We should remove dump_in_quirks_mode from initializers/json.rb


Related issues 2 (0 open2 closed)

Related to Foreman - Bug #7764: only generation of JSON objects or arrays allowedClosedShlomi Zadok10/01/2014Actions
Related to Foreman - Refactor #13697: Remove json gemClosedTomer Brisker02/14/2016Actions
Actions #1

Updated by Tom Caspy over 9 years ago

  • Status changed from New to Closed
  • Pull request https://github.com/theforeman/foreman/pull/2202 added
  • Pull request deleted ()
Actions #2

Updated by Shlomi Zadok over 9 years ago

  • Status changed from Closed to Assigned
  • Pull request added
  • Pull request deleted (https://github.com/theforeman/foreman/pull/2202)

Shouldn't be closed until this fixing the issue!
This issue is a reminder to undo the quirks_mode, as it will be supported from json ~> 1.8

Actions #3

Updated by Marek Hulán over 9 years ago

  • Related to Bug #7764: only generation of JSON objects or arrays allowed added
Actions #4

Updated by Tomer Brisker almost 9 years ago

Actions #5

Updated by Tomer Brisker almost 9 years ago

  • Status changed from Assigned to Ready For Testing
  • Assignee changed from Shlomi Zadok to Tomer Brisker
  • Pull request https://github.com/theforeman/foreman/pull/3178 added
Actions #6

Updated by Anonymous almost 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #7

Updated by Dominic Cleal almost 9 years ago

  • Category set to Rails
  • Translation missing: en.field_release set to 71
Actions

Also available in: Atom PDF