Project

General

Profile

Refactor #9553

remove dump_in_quirks_mode

Added by Shlomi Zadok over 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

We have created a method that adds quirks_mode => true to JSON.dump
From json ~> 1.8, this option is built into JSON.dump method
We should remove dump_in_quirks_mode from initializers/json.rb


Related issues

Related to Foreman - Bug #7764: only generation of JSON objects or arrays allowedClosed2014-10-01
Related to Foreman - Refactor #13697: Remove json gemClosed2016-02-14

Associated revisions

Revision 57000497 (diff)
Added by Tomer Brisker over 3 years ago

Fixes #9553 - Remove workaround for older json version

We already use json 1.8, this workaround is no longer needed.

History

#1 Updated by Tom Caspy over 4 years ago

  • Status changed from New to Closed
  • Pull request https://github.com/theforeman/foreman/pull/2202 added
  • Pull request deleted ()

#2 Updated by Shlomi Zadok over 4 years ago

  • Status changed from Closed to Assigned
  • Pull request added
  • Pull request deleted (https://github.com/theforeman/foreman/pull/2202)

Shouldn't be closed until this fixing the issue!
This issue is a reminder to undo the quirks_mode, as it will be supported from json ~> 1.8

#3 Updated by Marek Hulán over 4 years ago

  • Related to Bug #7764: only generation of JSON objects or arrays allowed added

#4 Updated by Tomer Brisker over 3 years ago

#5 Updated by Tomer Brisker over 3 years ago

  • Status changed from Assigned to Ready For Testing
  • Assignee changed from Shlomi Zadok to Tomer Brisker
  • Pull request https://github.com/theforeman/foreman/pull/3178 added

#6 Updated by Anonymous over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#7 Updated by Dominic Cleal over 3 years ago

  • Category set to Rails
  • Legacy Backlogs Release (now unused) set to 71

Also available in: Atom PDF