Project

General

Profile

Refactor #9590

Test for Host::Managed#info is too fragile

Added by Marek Hulán almost 7 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

we are testing the complete hash that is generated by info method, most of these values are not set explicitly so with any change to default values, the test gets broken, I'd like to test only values we set explicitly

also one related refactoring is that info method get primary subnet twice and then calls uniq

Associated revisions

Revision e24c3fbb (diff)
Added by Marek Hulán almost 7 years ago

Fixes #9590 - make info test less fragile

Revision 13895d05 (diff)
Added by Marek Hulán almost 7 years ago

Fixes #9590 - make info test less fragile

(cherry picked from commit e24c3fbbe5d089f76b89f909b65b2bd2205a5035)

History

#1 Updated by The Foreman Bot almost 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2213 added
  • Pull request deleted ()

#2 Updated by Marek Hulán almost 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal almost 7 years ago

  • Legacy Backlogs Release (now unused) set to 28

Also available in: Atom PDF