Project

General

Profile

Bug #9592

UI should report errors to the user when External AD UserGroup addition fails

Added by Marek Hulán almost 7 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1195637
Description of problem:

UI should report errors to the user when External AD UserGroup addition fails.

Processing by UsergroupsController#update as HTML
Parameters: {"utf8"=>"✓", "authenticity_token"=>"w4GDcBCBEdfi+TG0Lg7cPljNH4/96go+SS0giOfYNdY=", "usergroup"=>{"name"=>"foreman", "user_ids"=>["", "5", "", "4", "", "6", ""], "admin"=>"0", "role_ids"=>["", "11"], "external_usergroups_attributes"=>{"0"=>{"_destroy"=>"false", "name"=>"kedargrp", "auth_source_id"=>"4", "id"=>"8"}, "1"=>{"_destroy"=>"false", "name"=>"foobargroup", "auth_source_id"=>"3", "id"=>"7"}, "new_external_usergroups"=>{"_destroy"=>"false", "name"=>"", "auth_source_id"=>"3"}, "new_1424766851040"=>{"_destroy"=>"false", "name"=>"hdhdhd", "auth_source_id"=>"3"}}}, "id"=>"3-foreman"}
Failed to save: Name is not found in the authentication source

OR

Processing by UsergroupsController#update as HTML
Parameters: {"utf8"=>"✓", "authenticity_token"=>"w4GDcBCBEdfi+TG0Lg7cPljNH4/96go+SS0giOfYNdY=", "usergroup"=>{"name"=>"foreman", "user_ids"=>["", "5", "", "4", "", "6", ""], "admin"=>"0", "role_ids"=>["", "11"], "external_usergroups_attributes"=>{"0"=>{"_destroy"=>"false", "name"=>"kedargrp", "auth_source_id"=>"4", "id"=>"8"}, "1"=>{"_destroy"=>"false", "name"=>"foobargroup", "auth_source_id"=>"3", "id"=>"7"}, "new_external_usergroups"=>{"_destroy"=>"false", "name"=>"", "auth_source_id"=>"3"}, "new_1424767137133"=>{"_destroy"=>"false", "name"=>"foobargroup", "auth_source_id"=>"3"}}}, "id"=>"3-foreman"}
Failed to save: Name has already been taken

Version-Release number of selected component (if applicable):
sat6.1 Beta snap3

How reproducible:

Steps to Reproduce:
1. create usergroup
2. add an invalid external AD UserGroup.
3.

Actual results:
No error message seen on the UI.

foreman/production.log shows

a) "Failed to save: Name is not found in the authentication source"
b) Failed to save: Name has already been taken

Expected results:
Shouls display the actual error on the UI,
a) "Name is not found in the authentication source"
b) Name has already been taken

Additional info:

Associated revisions

Revision 8e170d21 (diff)
Added by Marek Hulán almost 7 years ago

Fixes #9592 - unfold external user groups on error

Revision 5ed4f721 (diff)
Added by Marek Hulán almost 7 years ago

Fixes #9592 - unfold external user groups on error

(cherry picked from commit 8e170d2186edc805e440e587438a4cf8207facd9)

History

#1 Updated by Marek Hulán almost 7 years ago

  • Category set to Web Interface
  • Status changed from New to Assigned
  • Priority changed from High to Normal

#2 Updated by The Foreman Bot almost 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2216 added
  • Pull request deleted ()

#3 Updated by Marek Hulán almost 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal almost 7 years ago

  • Legacy Backlogs Release (now unused) set to 28

Also available in: Atom PDF