Project

General

Profile

Bug #9615

while adding alias interface, mac should be auto populated based on attached_to interface

Added by Marek Hulán over 7 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Network
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1193460
Description of problem:
We don't have any validation around mac while adding an interface. I got to know we don't need mac when we add virtual interface.

Now let's say I've to configure alias of eth0, so in this case mac of alias would be same as of eth0. So UI should auto populate same mac as of attached_to interface i.e. eth0.

Or user should restrict to input mac address while defining new alias interface.

I can create alias interface without defining mac and add_interface form saved successfully. But if I do that then interface won't be configured at provisioned node.

In short, we should either of these:

1) either we should restrict user to input mac while alias interface via some validation/warning

2) Or UI should auto populate the mac of attached-to interface.

Version-Release number of selected component (if applicable):
Satellite-6.1.0-RHEL-6-20150210.0
Sat6.1.0 beta snap2

How reproducible:
always

Steps to Reproduce:
1. while creating new host, add alias interface without defining mac
2.
3.

Actual results:
alias interface won't be configured on provisioned node

Expected results:
UI should auto pick the mac of main interface to which we are attaching the alias.

Additional info:

Associated revisions

Revision e6df014b (diff)
Added by Marek Hulán over 7 years ago

Refs #9615 - Use parent interface MAC for virtual interfaces

closes GH-157

Revision 5ad3c4f3 (diff)
Added by Marek Hulán over 7 years ago

Fixes #9615 - Adds inheriting_mac method

Using this method we can find out the MAC of interface to which this
interface is attached to. This can be used in provisioning template when
we check for real interface name.

Revision 712bd3ea (diff)
Added by Marek Hulán over 7 years ago

Fixes #9615 - Adds inheriting_mac method

Using this method we can find out the MAC of interface to which this
interface is attached to. This can be used in provisioning template when
we check for real interface name.

(cherry picked from commit 5ad3c4f34b50fb1ac6d9f26e71e183813ab1c96f)

History

#1 Updated by Marek Hulán over 7 years ago

  • Category set to Network
  • Status changed from New to Assigned

It makes sense to modify the config template so we use parent interface in case the mac was not specified. There are use cases for all combinations.

#2 Updated by The Foreman Bot over 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2222 added
  • Pull request deleted ()

#3 Updated by Dominic Cleal over 7 years ago

  • Legacy Backlogs Release (now unused) set to 28

#4 Updated by Marek Hulán over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF