Bug #9716
Version comparison with Foreman breaks migrate
Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Difficulty:
Triaged:
No
Pull request:
Description
These lines (https://github.com/theforeman/foreman-docker/blob/master/lib/foreman_docker/engine.rb#L91-L95) lead to the following:
Malformed version number string 1.8.0-RC1 /opt/rh/ruby193/root/usr/share/rubygems/rubygems/version.rb:187:in `initialize' /opt/rh/ruby193/root/usr/share/gems/gems/foreman_docker-1.2.1/lib/foreman_docker/engine.rb:92:in `new' /opt/rh/ruby193/root/usr/share/gems/gems/foreman_docker-1.2.1/lib/foreman_docker/engine.rb:92:in `block (2 levels) in <class:Engine>' /usr/share/foreman/app/services/foreman/plugin.rb:62:in `instance_eval' /usr/share/foreman/app/services/foreman/plugin.rb:62:in `register'
Associated revisions
Fixes #9716 - Handle 1.8.0-rc1 version format
History
#1
Updated by Dominic Cleal about 8 years ago
I'd usually recommend that plugins branch rather than try to do version comparisons in code, it's more reliable...
#2
Updated by The Foreman Bot about 8 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman-docker/pull/99 added
- Pull request deleted (
)
#3
Updated by David Davis about 8 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset foreman-docker|8a1d63a334777b71ce765b985eab98615b27bb04.
#4
Updated by Dominic Cleal about 8 years ago
foreman_docker 1.2.2's now published to our repos with the fix.
Fixes #9716 - Handle 1.8.0-rc1 version format