Project

General

Profile

Bug #9773

Default profiles templates create invalid URL's

Added by Stephen Benjamin over 7 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Stephen Benjamin
Category:
Templates
Target version:
1.8.1
Difficulty:
Triaged:
Bugzilla link:
1136002
Pull request:
https://github.com/theforeman/foreman/pull/2268
Fixed in Releases:
Found in Releases:

Description

#4463 fixed this, but something introduced a regression where a protocol is being added twice:

ks=https://http://foreman.unattended.url/unattended/template/MyString2/Common

Related issues

Related to Foreman - Bug #4463: Default profiles templates default to https:// connection for kickstartClosed2014-02-26

Associated revisions

Revision f7174439 (diff)
Added by Stephen Benjamin about 7 years ago

fixes #9773 - correctly render template URL

Revision e2855a46 (diff)
Added by Stephen Benjamin about 7 years ago

fixes #9773 - correctly render template URL

(cherry picked from commit f7174439285708c3010605230fec16797f3a0763)

History

#1 Updated by Stephen Benjamin over 7 years ago

  • Related to Bug #4463: Default profiles templates default to https:// connection for kickstart added

#2 Updated by Stephen Benjamin over 7 years ago

The test isn't smart enough to catch it either, it should probably check for the entire "ks=http://...." string

#3 Updated by The Foreman Bot over 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2268 added
  • Pull request deleted ()

#4 Updated by Dominic Cleal about 7 years ago

  • Assignee set to Stephen Benjamin
  • Legacy Backlogs Release (now unused) set to 50

#5 Updated by Anonymous about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF