Project

General

Profile

Bug #9796

Badly marked translations for loading subscriptions loading screens

Added by Walden Raines about 8 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Walden Raines
Category:
Web UI
Target version:
Katello 2.3.0
Difficulty:
trivial
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/Katello/katello/pull/5116
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

The translations were marked like so:

        <td colspan="9" translate>
           <div class="loading-mask fa-3x" ng-show="working">
             <i class="fa fa-spinner fa-spin"></i>
             {{ "Loading..." | translate }}
           </div>
       </td>

Which results in the entire inside of the <td> being marked for translation. We should not be marking HTML for translation

Associated revisions

Revision b30b239f (diff)
Added by Walden Raines about 8 years ago

Fixes #9796: fix translations for subscription loading screens.

http://projects.theforeman.org/issues/9796

Revision 8506dc33
Added by Walden Raines about 8 years ago

Merge pull request #5116 from waldenraines/9796

Fixes #9796: fix translations for subscription loading screens.

History

#1 Updated by The Foreman Bot about 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/5116 added
  • Pull request deleted ()

#2 Updated by Walden Raines about 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Eric Helms almost 8 years ago

  • Legacy Backlogs Release (now unused) set to 31

Also available in: Atom PDF