Project

General

Custom queries

Profile

Actions
Copy link

Bug #9812

closed

'match' and 'value' parameters in override value's create should be required in apidoc

Added by Martin Bacovsky about 10 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Shlomi Zadok
Category:
API
Target version:
1.9.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/2255
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Currently it allows CLI to attempt to create override value without these params which result in 500.

[ INFO 2015-03-18 16:00:34 API] POST /api/smart_variables/205/override_values
[DEBUG 2015-03-18 16:00:34 API] Params: {
    "override_value" => {}
}
[DEBUG 2015-03-18 16:00:34 API] Headers: {}
[DEBUG 2015-03-18 16:00:35 API] 500 Internal Server Error
{
    "error" => {
        "message" => "undefined method `match' for nil:NilClass" 
    }
}

Related issues 3 (0 open — 3 closed)

Related to Foreman - Bug #10528: Can't save a smart class parameter/smart variable with the value 'false'ClosedTom Caspy05/17/2015Actions
Related to Foreman - Bug #9187: Overrideable empty puppet class parameters are still validate their default valueClosedOri Rabin02/02/2015Actions
Related to Foreman - Bug #11663: Empty lookup value validated even when use_puppet_default is checkedClosedOri Rabin09/02/2015Actions
Actions
Copy link
 #1

Updated by Tomáš Strachota about 10 years ago

Not only they should be required in the docs but we must make sure the api can cope with the missing parameters and not to fail with 500.

Actions
Copy link
 #3

Updated by Shlomi Zadok about 10 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF