Project

General

Profile

Bug #9840

BMC providers should return 501 error code when they don't implement the api call

Added by Corey Osman about 8 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Corey Osman
Category:
BMC
Target version:
1.9.0
Difficulty:
easy
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/smart-proxy/pull/264
Fixed in Releases:
Found in Releases:
Foreman - Nightly
Red Hat JIRA:

Description

If we call a method that has not been implemented in a given provider the proxy will fail to respond correctly and throw a stacktrace because a method was called and the provider has not implemented it.

I would expected that and http error code of 501 (Not Implemented) be thrown to notify the user.

Associated revisions

Revision e9171900 (diff)
Added by Corey Osman about 8 years ago

Fixes #9840 - BMC providers should return 501 error code when they don't implement the api call

  • catches the NotImplementedError properely and returns 501 http code
  • fixes rubocop warnings

History

#1 Updated by Dominic Cleal about 8 years ago

  • Status changed from New to Ready For Testing
  • Legacy Backlogs Release (now unused) set to 35
  • Pull request https://github.com/theforeman/smart-proxy/pull/264 added
  • Pull request deleted ()

#2 Updated by Corey Osman about 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF