Project

General

Profile

Bug #9896

TFTP Servername can be set incorrectly

Added by Stephen Benjamin over 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Foreman modules
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

/etc/foreman-proxy/settings.d/tftp.yaml has tftp_servername set always, but the logic in the foreman-proxy module looks for ipaddress_eth0, and then if not present, ipaddress.

This totally breaks on el7/newer Fedora, where you're not guaranteed to have eth0 anymore, and if you have something like the "docker0" interface, because then that becomes $::ipaddress. All your hosts next-server is set to the docker0 interface IP.

Why set this parameter tftp_servername at all? Seems to work without it.

Associated revisions

Revision c762f632 (diff)
Added by Stephen Benjamin about 7 years ago

fixes #9896 - don't set tftp_servername by default

Revision fd1a9b8f (diff)
Added by Dominic Cleal about 7 years ago

refs #9896 - only validate tftp_servername when set

History

#1 Updated by Stephen Benjamin over 7 years ago

  • Bugzilla link set to 1205729

#2 Updated by Dominic Cleal over 7 years ago

Why set this parameter tftp_servername at all? Seems to work without it.

Depends ultimately on the network layout as to whether it's needed. The default could probably be removed though, which would work for simple cases.

#3 Updated by Anonymous about 7 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF