Actions
Bug #9919
closedtrusted host test can hang during DNS lookup
Description
One of the trusted hosts tests added in #7849 hangs in my local environment. Perhaps network or smart proxy config differences, as it's actually going to the network to perform a DNS lookup.
/home/dcleal/.rvm/rubies/ruby-2.1.0/lib/ruby/2.1.0/resolv.rb:101:in `getaddresses' /home/dcleal/code/foreman/smart-proxy/lib/proxy/helpers.rb:59:in `remote_fqdn' /home/dcleal/code/foreman/smart-proxy/lib/sinatra/authorization.rb:17:in `block in authorize_with_trusted_hosts' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:1610:in `call' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:1610:in `block in compile!' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:1014:in `[]' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:1014:in `block in process_route' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:1012:in `catch' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:1012:in `process_route' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:965:in `block in filter!' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:965:in `each' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:965:in `filter!' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:1083:in `block in dispatch!' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:1066:in `block in invoke' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:1066:in `catch' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:1066:in `invoke' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:1081:in `dispatch!' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:906:in `block in call!' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:1066:in `block in invoke' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:1066:in `catch' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:1066:in `invoke' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:906:in `call!' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:894:in `call' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/rack-protection-1.5.3/lib/rack/protection/xss_header.rb:18:in `call' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/rack-protection-1.5.3/lib/rack/protection/path_traversal.rb:16:in `call' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/rack-protection-1.5.3/lib/rack/protection/json_csrf.rb:18:in `call' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/rack-protection-1.5.3/lib/rack/protection/base.rb:49:in `call' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/rack-protection-1.5.3/lib/rack/protection/base.rb:49:in `call' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/rack-protection-1.5.3/lib/rack/protection/frame_options.rb:31:in `call' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/rack-1.5.2/lib/rack/nulllogger.rb:9:in `call' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/rack-1.5.2/lib/rack/head.rb:11:in `call' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/show_exceptions.rb:21:in `call' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:181:in `call' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/sinatra-1.4.6/lib/sinatra/base.rb:2021:in `call' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/rack-test-0.6.3/lib/rack/mock_session.rb:30:in `request' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/rack-test-0.6.3/lib/rack/test.rb:244:in `process_request' /home/dcleal/.rvm/gems/ruby-2.1.0@proxy/gems/rack-test-0.6.3/lib/rack/test.rb:58:in `get' /home/dcleal/.rvm/rubies/ruby-2.1.0/lib/ruby/2.1.0/forwardable.rb:183:in `get' test/sinatra/trusted_hosts_test.rb:61:in `test_trusted_hosts_http_forbids_access'
Updated by The Foreman Bot over 9 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/smart-proxy/pull/271 added
- Pull request deleted (
)
Updated by Dominic Cleal over 9 years ago
- Related to Feature #7849: trusted_hosts should determine hostname from certificate CN on SSL requests added
Updated by Dominic Cleal over 9 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset b8e4d4721da11013e22d3b96e2b98e367f16fede.
Updated by Dominic Cleal over 9 years ago
- Translation missing: en.field_release set to 35
Actions