Project

General

Profile

Bug #9966

Add debug logging when host interfaces cannot be matched to VM interfaces

Added by Dominic Cleal over 6 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Category:
Network
Target version:
Difficulty:
easy
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

#7456 changes compute orchestration to match host interfaces to the VM interfaces, which is usually matching based on the hypervisor network.

The orchestration iterates over host interfaces and attempts to find a VM interface, but if this fails then there's no logging provided to debug the situation.

https://github.com/theforeman/foreman/blob/1.8.0-RC2/app/models/concerns/orchestration/compute.rb#L294-L295

Here's an example of adding some debug:
https://github.com/theforeman/foreman/compare/develop...tstrachota:nic_debug


Related issues

Related to Foreman - Refactor #7456: Extract primary interface from hostClosed2014-09-16
Related to Foreman - Bug #9871: Provisioning a new vmware hosts fails with 'Invalid MAC 'Resolved2015-03-23

Associated revisions

Revision c7966090 (diff)
Added by Tomáš Strachota over 6 years ago

Fixes #9966 - More debug messages for matching nics from fog

Revision 180c2696 (diff)
Added by Tomáš Strachota over 6 years ago

Fixes #9966 - More debug messages for matching nics from fog

(cherry picked from commit c796609085caeee03be4ec378b5311fd61ba6684)

History

#1 Updated by Dominic Cleal over 6 years ago

  • Related to Refactor #7456: Extract primary interface from host added

#2 Updated by Dominic Cleal over 6 years ago

  • Related to Bug #9871: Provisioning a new vmware hosts fails with 'Invalid MAC ' added

#3 Updated by Dominic Cleal over 6 years ago

Perhaps it should be more than debug level when matching fails? Should it even fail the entire process so users don't get "invalid MAC" errors etc.

#4 Updated by Dominic Cleal over 6 years ago

  • Legacy Backlogs Release (now unused) set to 28
  • Difficulty set to easy

#5 Updated by Dominic Cleal over 6 years ago

  • Legacy Backlogs Release (now unused) changed from 28 to 50

#6 Updated by Tomáš Strachota over 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Tomáš Strachota

#7 Updated by Marek Hulán over 6 years ago

based on IRC discussion we should trigger failure if the matching fails

#8 Updated by The Foreman Bot over 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2360 added
  • Pull request deleted ()

#9 Updated by Anonymous over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF