Project

General

Profile

Bug #9967

Unit tests do not isolate user setup

Added by Marek Hulán over 6 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Marek Hulán
Category:
Tests
Target version:
1.8.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/2278
Fixed in Releases:
Found in Releases:

Description

On several places we set User.current in setup or even in test method without clearing the value afterwards.

Related issues

Blocked by Katello - Bug #9979: Organization spec tests do not configure User.current during setupClosed2015-03-31
Blocks Foreman - Bug #9947: CVE-2015-1844 - GET /api/hosts doesn't respect organization/location membershipClosed2015-03-30

Associated revisions

Revision fbbda128 (diff)
Added by Marek Hulán over 6 years ago

Fixes #9967 - make sure User.current is isolated

Revision ec7e8a8f (diff)
Added by Marek Hulán over 6 years ago

Fixes #9967 - make sure User.current is isolated

(cherry picked from commit fbbda1282c4ea4f17bd12132aa61f4a66832e8b8)

History

#1 Updated by The Foreman Bot over 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2278 added
  • Pull request deleted ()

#2 Updated by Eric Helms over 6 years ago

  • Blocked by Bug #9979: Organization spec tests do not configure User.current during setup added

#3 Updated by Marek Hulán over 6 years ago

  • Blocks Bug #9947: CVE-2015-1844 - GET /api/hosts doesn't respect organization/location membership added

#4 Updated by Marek Hulán over 6 years ago

  • Legacy Backlogs Release (now unused) set to 40

#5 Updated by Marek Hulán over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Dominic Cleal over 6 years ago

  • Legacy Backlogs Release (now unused) changed from 40 to 28

Also available in: Atom PDF