Project

General

Profile

Bug #9971

hammer erratum list: Search with repository name fails

Added by Martin Bacovsky over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Category:
Foreman commands (obsolete)
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:
In Kanboard:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1180644
Description of problem:
hammer erratum list: Search with repository name fails

Version-Release number of selected component (if applicable):
  • apr-util-ldap-1.3.9-3.el6_0.1.x86_64
  • candlepin-0.9.37-1.el6.noarch
  • candlepin-common-1.0.17-1.el6.noarch
  • candlepin-selinux-0.9.37-1.el6.noarch
  • candlepin-tomcat6-0.9.37-1.el6.noarch
  • elasticsearch-0.90.10-7.el6.noarch
  • foreman-1.8.0-0.develop.201501051457git6529247.el6.noarch
  • foreman-compute-1.8.0-0.develop.201501051457git6529247.el6.noarch
  • foreman-gce-1.8.0-0.develop.201501051457git6529247.el6.noarch
  • foreman-libvirt-1.8.0-0.develop.201501051457git6529247.el6.noarch
  • foreman-ovirt-1.8.0-0.develop.201501051457git6529247.el6.noarch
  • foreman-postgresql-1.8.0-0.develop.201501051457git6529247.el6.noarch
  • foreman-proxy-1.8.0-0.develop.201412301259gite2ce2a0.el6.noarch
  • foreman-release-1.8.0-0.develop.201501051457git6529247.el6.noarch
  • foreman-selinux-1.8.0-0.develop.201412151103gite2863e4.el6.noarch
  • foreman-vmware-1.8.0-0.develop.201501051457git6529247.el6.noarch
  • katello-2.1.0-1.201411061509gitb0b8f43.el6.noarch
  • katello-certs-tools-2.0.1-1.el6.noarch
  • katello-default-ca-1.0-1.noarch
  • katello-installer-2.2.0-1.201412192027git113612b.el6.noarch
  • katello-installer-base-2.2.0-1.201412192027git113612b.el6.noarch
  • katello-repos-2.1.1-1.el6.noarch
  • katello-server-ca-1.0-1.noarch
  • openldap-2.4.23-32.el6_4.1.x86_64
  • openldap-devel-2.4.23-32.el6_4.1.x86_64
  • pulp-docker-plugins-0.2.1-0.2.beta.el6.noarch
  • pulp-katello-0.3-3.el6.noarch
  • pulp-nodes-common-2.5.1-1.el6.noarch
  • pulp-nodes-parent-2.5.1-1.el6.noarch
  • pulp-puppet-plugins-2.5.1-1.el6.noarch
  • pulp-puppet-tools-2.5.1-1.el6.noarch
  • pulp-rpm-plugins-2.5.1-1.el6.noarch
  • pulp-selinux-2.5.1-1.el6.noarch
  • pulp-server-2.5.1-1.el6.noarch
  • python-ldap-2.3.10-1.el6.x86_64
  • ruby193-rubygem-ldap_fluff-0.3.3-1.el6.noarch
  • ruby193-rubygem-net-ldap-0.10.0-1.el6.noarch
  • ruby193-rubygem-runcible-1.3.0-1.el6.noarch

How reproducible:
Always

Steps to Reproduce:
1. Create two orgs - Org1 and Org2.
2. Create a repository and product in both the orgs and sync them. Make sure both the repos have some erratas.
Org1Product - Org1Repo
Org2Product - Org2Repo
2. Now run the cli command:
hammer> erratum list --repository=Org1Repo

Actual results:
The command runs without errors but displays all errata info from all repos (from Org2Repo) as well.

But the following command displays right erratas.
hammer> erratum list --repository=Org1Repo --organization=Org1 --product=Org1Product

Expected results:
Make product info and org info mandatory when searching with repository name.

Additional info:
Alternatively the following command works fine:
hammer> erratum list --repository-id=7


Related issues

Blocks Foreman - Tracker #10226: Core Sprint 1Resolved2015-04-202015-05-10

Associated revisions

Revision cb147071 (diff)
Added by Martin Bačovský over 7 years ago

Fixes #9971 -improve handling of id search errors

Do not hide search failures when intentionaly looking for non-required resource id

Revision adfe4656
Added by mbacovsky over 7 years ago

Merge pull request #175 from mbacovsky/9971_non_req_search

Fixes #9971 - improve handling of id search errors

History

#1 Updated by Martin Bacovsky over 7 years ago

  • Category set to Foreman commands (obsolete)
  • Status changed from New to Assigned
  • Assignee changed from Stephen Benjamin to Martin Bacovsky

#2 Updated by The Foreman Bot over 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/175 added
  • Pull request deleted ()

#3 Updated by Martin Bacovsky over 7 years ago

When hammer is trying to find out what id repository=Org1Repo has, it fails on missing organization. As repository_id is not mandatory parameter, the error is ignored and list command is performed without the repository_id filter.

In the related PR I fixed the behaviour to not ignore search errors on non-mandatory parameters when they were specified by name on CLI.

With the fix the above mentioned list ends up with:

Error: Could not find organization, please set one of options --organization, --organization-label, --organization-id

#4 Updated by Eric Helms over 7 years ago

#5 Updated by Anonymous over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF